Reviewers: jtamplin, unnurg,
Description:
xhr.responseType was misspelled as responsetype (lowercase t)
Issue 7386
Please review this at https://gwt-code-reviews.appspot.com/1820806/
Affected files:
M user/src/com/google/gwt/xhr/client/XMLHttpRequest.java
Index:
LGTM
I swear I remember this being fixed some time ago, but apparently not.
We really need to get an updated HtmlUnit so we can have automated tests
for some of these things.
https://gwt-code-reviews.appspot.com/1820806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/09/09 23:24:59, jtamplin wrote:
We really need to get an updated HtmlUnit so we can have automated
tests for
some of these things.
I don't know the status of HtmlUnit, but trying new versions should be
made much easier with the move Maven. That being said, I skimmed
HtmlUnit's Web
On 2012/09/09 23:35:48, tbroyer wrote:
I don't know the status of HtmlUnit, but trying new versions should be
made much
easier with the move Maven. That being said, I skimmed HtmlUnit's Web
site and
it doesn't seem to support either TypedArrays or xhr.responseType :-(
Yes, I meant make the
Reviewers: skybrian,
Description:
EditorDriver#setConstraintViolations used to thrown NPE if arg was null.
Issue 6578
Please review this at https://gwt-code-reviews.appspot.com/1826803/
Affected files:
M user/src/com/google/gwt/editor/client/impl/SimpleViolation.java
M
https://gwt-code-reviews.appspot.com/1826803/diff/2001/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java
File
user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java
(right):
https://gwt-code-reviews.appspot.com/1826803/diff/2001/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java
File
user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java
(right):
