On 2012/09/14 18:53:22, rdayal wrote:
I think this one is going to be pushed past GWT 2.5; that's ok though.
http://gwt-code-reviews.appspot.com/1829803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
My 2 c€nts
http://gwt-code-reviews.appspot.com/1831803/diff/1/user/src/com/google/gwt/aria/client/Roles.java
File user/src/com/google/gwt/aria/client/Roles.java (right):
http://gwt-code-reviews.appspot.com/1831803/diff/1/user/src/com/google/gwt/aria/client/Roles.java#newcode137
user/src/com/goo
http://gwt-code-reviews.appspot.com/1829803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/09/14 14:37:01, rdayal wrote:
Pair-reviewed by drfibonacci and rdayal.
LGTM.
http://gwt-code-reviews.appspot.com/1828803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Fri, Sep 14, 2012 at 10:23 AM, wrote:
>
> I haven't quite figured out why, but actually code like this does seem
> to cause a memory leak in Chrome. It essentially causes V8 to retain the
> entire (textual) JS source of your program in memory, I think so that if
> you debug a breakpoint, the D
Hey Thomas, great comments, thanks. I will update the patch shortly with
fixes. One issue is that V8 doesn't seem to be as great at GC as I
thought, and I'm going to have to speak to the Chrome team. I thought
originally that anything not reachable from GC roots would ultimately be
collected, but
LGTM. Thanks!
http://gwt-code-reviews.appspot.com/1831803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hey Thomas,
Thanks for looking this over. I'll reply to the code-specific comments in
Rietveld itself, but I thought I'd respond to your more pressing concerns
first.
On Fri, Sep 14, 2012 at 10:57 AM, wrote:
> I'm sorry I've only started to review the files (over the last few days)
> but I have
I'm sorry I've only started to review the files (over the last few days)
but I have a first question/comment about where this is going:
There are many things that are not needed in the case of MobileWebApp as
the host page is protected behind authentication. Because the user won't
ever see this p
http://gwt-code-reviews.appspot.com/1829803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1828803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Upgrade GAE version
http://gwt-code-reviews.appspot.com/1829803/diff/4001/samples/mobilewebapp/pom.xml
File samples/mobilewebapp/pom.xml (right):
http://gwt-code-reviews.appspot.com/1829803/diff/4001/samples/mobilewebapp/pom.xml#newcode21
samples/mobilewebapp/pom.xml:21: 1.5.3
Upgrade to 1.7.1
Possibly related:
http://code.google.com/p/google-web-toolkit/issues/detail?id=1821
http://gwt-code-reviews.appspot.com/1827804/diff/1/user/src/com/google/gwt/core/client/GWT.java
File user/src/com/google/gwt/core/client/GWT.java (right):
http://gwt-code-reviews.appspot.com/1827804/diff/1/user/
13 matches
Mail list logo
