Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2040
Change subject: Introduces a common SerializableThrowable and refactors
StackTraceDeobfuscator as public API.
..
Introduces a
http://gwt-code-reviews.appspot.com/1891804/diff/7001/user/src/com/google/gwt/animation/client/Animation.java
File user/src/com/google/gwt/animation/client/Animation.java (right):
http://gwt-code-reviews.appspot.com/1891804/diff/7001/user/src/com/google/gwt/animation/client/Animation.java#newcod
Roberto Lublinerman has abandoned this change.
Change subject: Fix SpeedTracer Log when compilation is spread across
different processes.
..
Abandoned
Submitted, Thanks!
--
To view, visit https://gwt-review.googlesource.co
Brian Slesinsky has posted comments on this change.
Change subject: Fix SpeedTracer Log when compilation is spread across
different processes.
..
Patch Set 1: Code-Review+1
Sure, makes sense.
--
To view, visit https://gwt-
On 2013/02/28 01:45:15, jtam wrote:
Switched to Public. Not sure what you would like me to do in terms of
unit
tests. This is just exposing an internal which should be already
tested.
I think just adding appropriate asserts for isRunning()'s return value
to AnimationTest would be sufficient.
http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java
File user/src/com/google/gwt/animation/client/Animation.java (right):
http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java#newcode203
u
Why protected? Also, shouldn't the unit tests be updated?
http://gwt-code-reviews.appspot.com/1891804/
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
T
Matthew Dempsky has posted comments on this change.
Change subject: Fix SpeedTracer Log when compilation is spread across
different processes.
..
Patch Set 1: Code-Review+1
Seems to make sense to me.
--
To view, visit http
Roberto Lublinerman has uploaded a new change for review.
https://gwt-review.googlesource.com/2031
Change subject: Fix SpeedTracer Log when compilation is spread across
different processes.
..
Fix SpeedTracer Log when com
Matthew Dempsky has posted comments on this change.
Change subject: Remove unnecessary wrapping of IOException in
DiskCacheToken. This just increases stack trace verbosity, since the
callers either throw IOException already or could easily do so.
.
Matthew Dempsky has posted comments on this change.
Change subject: Removes deprecated methods from JUnitShell.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/2030
To unsubscribe, visit htt
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2030
Change subject: Removes deprecated methods from JUnitShell.
..
Removes deprecated methods from JUnitShell.
Change-Id: I0e3fc2b07
Matthew Dempsky has posted comments on this change.
Change subject: Remove unnecessary wrapping of IOException in
DiskCacheToken. This just increases stack trace verbosity, since the
callers either throw IOException already or could easily do so.
.
Brian Slesinsky has uploaded a new change for review.
https://gwt-review.googlesource.com/2020
Change subject: Remove unnecessary wrapping of IOException in
DiskCacheToken. This just increases stack trace verbosity, since the
callers either throw IOException already or could easily do so.
14 matches
Mail list logo
