[gwt-contrib] Re: corrects typos (issue1902803)

2013-04-17 Thread rluble
Ray, are these public methods used at all by custom linkers or any other user code? http://gwt-code-reviews.appspot.com/1902803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit

[gwt-contrib] Change in gwt[master]: Add callbacks to Super Dev Mode to find out when a compile s...

2013-04-17 Thread Brian Slesinsky
Brian Slesinsky has abandoned this change. Change subject: Add callbacks to Super Dev Mode to find out when a compile starts and finishes, and an alternate main() that can be called after parsing options. .. Abandoned Sub

[gwt-contrib] Change in gwt[master]: Add callbacks to Super Dev Mode to find out when a compile s...

2013-04-17 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Add callbacks to Super Dev Mode to find out when a compile starts and finishes, and an alternate main() that can be called after parsing options. .. Patch

[gwt-contrib] Re: corrects typos (issue1902803)

2013-04-17 Thread mdempsky
On 2013/04/17 23:12:34, mdempsky wrote: Face palm. (And that's at the typos being overlooked for so long, not at the patch!) http://gwt-code-reviews.appspot.com/1902803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscri

[gwt-contrib] Re: corrects typos (issue1902803)

2013-04-17 Thread mdempsky
Face palm. Does this break backwards compatibility at all? E.g., are any of the permuation methods user accessible? Do we need to add @Deprecated forwarding methods for them? http://gwt-code-reviews.appspot.com/1902803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors ---

[gwt-contrib] Re: corrects typos (issue1902803)

2013-04-17 Thread rluble
LGTM. I can not believe that this was not caught by anyone before. http://gwt-code-reviews.appspot.com/1902803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" g

[gwt-contrib] Change in gwt[master]: Fixes ISSUE 7079 - Add support for the newer bindery Handler...

2013-04-17 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Fixes ISSUE 7079 - Add support for the newer bindery HandlerRegistration .. Patch Set 1: Verified+1 Hoorays, this change passed presubmit. :D More details

[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.

2013-04-17 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 1: Verified-1 Oops, this change failed presubmit. :( More details at -- To view, visit

[gwt-contrib] Re: documents and tests the fact that the ArgProcessor allows duplicate args and honors the last one (issue1901803)

2013-04-17 Thread rluble
On 2013/04/17 21:10:31, stalcup wrote: LGTM. BTW, we are using gwt-review.googlesource.com http://gwt-code-reviews.appspot.com/1901803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google We

[gwt-contrib] Change in gwt[master]: Add callbacks to Super Dev Mode to find out when a compile s...

2013-04-17 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Add callbacks to Super Dev Mode to find out when a compile starts and finishes, and an alternate main() that can be called after parsing options. .. Patch

Re: [gwt-contrib] Re: RequestFactory Feature Request: @Immutable EntityProxy, reduced payload size, Map support.

2013-04-17 Thread Thomas Broyer
On Wednesday, April 17, 2013 12:17:25 PM UTC+2, James Horsley wrote: > > Hey Thomas, > > Totally understand that modularization and mavenization are top priorities > but does that mean my Map support patch need to wait until after GWT 2.6? > I'm afraid it'll have to; or put differently I can't

[gwt-contrib] Change in gwt[master]: Add explicit assertNonNull() statements to JSONTest for clea...

2013-04-17 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Add explicit assertNonNull() statements to JSONTest for cleaner test failures. .. Patch Set 1: Verified-1 testing -- To view, visit https://gwt-review.goo

[gwt-contrib] Re: Fixing AbsolutePanel to set positioning of 'right' instead of 'left' for RTL languages. Without ... (issue1900803)

2013-04-17 Thread goktug
Thanks Andrew & John! Yes, agreed. Having RTL-aware methods makes sense: setWidgetPosition => sets left for backward compatibility setWidgetLeftPosition => sets left setWidgetRightPosition => sets right setWidgetLineStartPosition => sets left if LTR, right if RTL setWidgetLineEnd

[gwt-contrib] Re: Fixing AbsolutePanel to set positioning of 'right' instead of 'left' for RTL languages. Without ... (issue1900803)

2013-04-17 Thread andrewbachmann
DockLayoutPanel separates line_start from west, and it seems like it would be appropriate to separate line_start from left in this situation. This way would be backwards compatible. To fix the problem in the description, it would be necessary to add a new RTL-aware add method, similar to DockLay

[gwt-contrib] Change in gwt[master]: Avoid creating anonymous inner classes with wildcard type pa...

2013-04-17 Thread Roberto Lublinerman
Roberto Lublinerman has abandoned this change. Change subject: Avoid creating anonymous inner classes with wildcard type parameters. .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/247

[gwt-contrib] Re: Fixing AbsolutePanel to set positioning of 'right' instead of 'left' for RTL languages. Without ... (issue1900803)

2013-04-17 Thread jat
On 2013/04/17 17:21:49, goktug wrote: On 2013/04/17 05:14:32, yaminik wrote: Reviewers needed. I don't have much experience with RTL issues. At least this change will very likely break any previous code that was not assuming the different behavior for RTL in AbsolutePanel. I would lo

[gwt-contrib] Re: Fixing AbsolutePanel to set positioning of 'right' instead of 'left' for RTL languages. Without ... (issue1900803)

2013-04-17 Thread goktug
On 2013/04/17 05:14:32, yaminik wrote: Reviewers needed. I don't have much experience with RTL issues. At least this change will very likely break any previous code that was not assuming the different behavior for RTL in AbsolutePanel. I would love to hear what you guys think. http://gwt-code-

[gwt-contrib] Change in gwt[master]: Avoid creating anonymous inner classes with wildcard type pa...

2013-04-17 Thread Roberto Lublinerman
Roberto Lublinerman has uploaded a new patch set (#7). Change subject: Avoid creating anonymous inner classes with wildcard type parameters. .. Avoid creating anonymous inner classes with wildcard type parameters. Under Java

[gwt-contrib] Change in gwt[master]: Fix non deterministic behaviour in TypeTightener.

2013-04-17 Thread Roberto Lublinerman
Roberto Lublinerman has abandoned this change. Change subject: Fix non deterministic behaviour in TypeTightener. .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/2530 To unsubscribe, visit

Re: [gwt-contrib] Re: RequestFactory Feature Request: @Immutable EntityProxy, reduced payload size, Map support.

2013-04-17 Thread James Horsley
Hey Thomas, Totally understand that modularization and mavenization are top priorities but does that mean my Map support patch need to wait until after GWT 2.6? I know things have been in a transitional period but I submitted the patch almost a year ago now and would love to get the support in; le

[gwt-contrib] Change in gwt[master]: Add callbacks to Super Dev Mode to find out when a compile s...

2013-04-17 Thread James Nelson
James Nelson has posted comments on this change. Change subject: Add callbacks to Super Dev Mode to find out when a compile starts and finishes, and an alternate main() that can be called after parsing options. .. Patch Se