[gwt-contrib] Change in gwt[master]: Add interfaces for widgets.

2013-06-07 Thread Stephen Haberman
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3231 to look at the new patch set (#2). Change subject: Add interfaces for widgets. .. Add interfaces for widgets

[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().

2013-06-07 Thread Goktug Gokdogan
Goktug Gokdogan has uploaded a new patch set (#2). Change subject: Adds Timer#isRunning(). .. Adds Timer#isRunning(). This patch uses Integer instead of int to keep track of the running status. As now, running state is kept, ca

[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().

2013-06-07 Thread Goktug Gokdogan
Goktug Gokdogan has uploaded a new change for review. https://gwt-review.googlesource.com/3321 Change subject: Adds Timer#isRunning(). .. Adds Timer#isRunning(). This patch uses Integer instead of int to keep track of the r

[gwt-contrib] Change in gwt[master]: fixes a compiler crash when parsing illegal runAsync definit...

2013-06-07 Thread John Stalcup
John Stalcup has posted comments on this change. Change subject: fixes a compiler crash when parsing illegal runAsync definitions .. Patch Set 1: see https://code.google.com/p/google-web-toolkit/issues/detail?id=6739 -- To

[gwt-contrib] Change in gwt[master]: fixes a compiler crash when parsing illegal runAsync definit...

2013-06-07 Thread John Stalcup
John Stalcup has uploaded a new change for review. https://gwt-review.googlesource.com/3320 Change subject: fixes a compiler crash when parsing illegal runAsync definitions .. fixes a compiler crash when parsing illegal r

[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...

2013-06-07 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. .. Patch Set 2: (1 comment) Thi

[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...

2013-06-07 Thread John Stalcup
John Stalcup has posted comments on this change. Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. .. Patch Set 2: yes this is in resp

[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...

2013-06-07 Thread Ray Cromwell
Ray Cromwell has posted comments on this change. Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. .. Patch Set 2: Is there a bug file

[gwt-contrib] Change in gwt[master]: Adds a module to revert GWT.runAsync to do immediate callbac...

2013-06-07 Thread Goktug Gokdogan
Goktug Gokdogan has uploaded a new change for review. https://gwt-review.googlesource.com/3310 Change subject: Adds a module to revert GWT.runAsync to do immediate callbacks in consecutive calls. .. Adds a module to rever

[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...

2013-06-07 Thread John Stalcup
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3300 to look at the new patch set (#2). Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors.

[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...

2013-06-07 Thread John Stalcup
John Stalcup has uploaded a new change for review. https://gwt-review.googlesource.com/3300 Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. ...

[gwt-contrib] Change in gwt[master]: FileUpload: extending FocusWidget instead of Widget so as it...

2013-06-07 Thread Manuel Carrasco Moñino
Manuel Carrasco Moñino has posted comments on this change. Change subject: FileUpload: extending FocusWidget instead of Widget so as it exposes many features which already are in the file-input element: click(), focus(), mouseevents, keyevents, etc. ..

[gwt-contrib] Change in gwt[master]: Enable EntityProxyId as an RequestFactory service method arg...

2013-06-07 Thread Daniel Kurka
Daniel Kurka has posted comments on this change. Change subject: Enable EntityProxyId as an RequestFactory service method argument. .. Patch Set 1: (5 comments) File u

Re: [gwt-contrib] widget interfaces

2013-06-07 Thread Stephen Haberman
Hi Ed, > FYI: the IsElement interfaces corresponds to issue 7497: > http://code.google.com/p/google-web-toolkit/issues/detail?id=7497 Oh, right, I forgot about that...well, maybe it will go in after all. :-) - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You r

[gwt-contrib] Change in gwt[master]: FileUpload: extending FocusWidget instead of Widget so as it...

2013-06-07 Thread Patrick Tucker
Patrick Tucker has posted comments on this change. Change subject: FileUpload: extending FocusWidget instead of Widget so as it exposes many features which already are in the file-input element: click(), focus(), mouseevents, keyevents, etc. ..

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-06-07 Thread John Ahlroos
Hello Leeroy Jenkins, Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2900 to look at the new patch set (#11). Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload

[gwt-contrib] Change in gwt[master]: Add support for the newer bindery HandlerRegistration Bug:...

2013-06-07 Thread Julien Dramaix
Julien Dramaix has posted comments on this change. Change subject: Add support for the newer bindery HandlerRegistration Bug: issue 7079 Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 .. Patch Set 6: Thomas I create

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-06-07 Thread John Ahlroos
John Ahlroos has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 10: Leeroy seems to be in a bad mood today :) -- To view, visit https://g

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-06-07 Thread John Ahlroos
Hello Leeroy Jenkins, Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2900 to look at the new patch set (#10). Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload

[gwt-contrib] Change in gwt[master]: FileUpload: extending FocusWidget instead of Widget so as it...

2013-06-07 Thread Manuel Carrasco Moñino
Manuel Carrasco Moñino has posted comments on this change. Change subject: FileUpload: extending FocusWidget instead of Widget so as it exposes many features which already are in the file-input element: click(), focus(), mouseevents, keyevents, etc. ..

[gwt-contrib] Re: Make PopupPanel#setAnimationType public (issue1893803)

2013-06-07 Thread t . broyer
If you still care about it, could you please move the patch over to Gerrit? http://www.gwtproject.org/makinggwtbetter.html http://gwt-code-reviews.appspot.com/1893803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to t

[gwt-contrib] Change in gwt[master]: FileUpload: extending FocusWidget instead of Widget so as it...

2013-06-07 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: FileUpload: extending FocusWidget instead of Widget so as it exposes many features which already are in the file-input element: click(), focus(), mouseevents, keyevents, etc. ...

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-06-07 Thread John Ahlroos
Hello Leeroy Jenkins, Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2900 to look at the new patch set (#9). Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-06-07 Thread John Ahlroos
John Ahlroos has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 7: (2 comments) File

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-06-07 Thread John Ahlroos
Hello Leeroy Jenkins, Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2900 to look at the new patch set (#8). Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .

[gwt-contrib] Change in gwt[master]: Add support for 'ImageResource' to @url substitution in css....

2013-06-07 Thread Daniel Kurka
Daniel Kurka has posted comments on this change. Change subject: Add support for 'ImageResource' to @url substitution in css. Only 'DataResource' used to be supported. .. Patch Set 1: Code-Review+1 -- To view, visit https:/

Re: [gwt-contrib] widget interfaces

2013-06-07 Thread Ed Bras
FYI: the IsElement interfaces corresponds to issue 7497: http://code.google.com/p/google-web-toolkit/issues/detail?id=7497 On Fri, Jun 7, 2013 at 5:03 AM, Stephen Haberman wrote: > > > If nobody else has any other concerns, I recommend you to start with > > an example interface to get early fee