[gwt-contrib] Change in gwt[master]: Adds Node#removeAllChildren.

2013-06-20 Thread Manuel Carrasco Moñino
Manuel Carrasco Moñino has posted comments on this change. Change subject: Adds Node#removeAllChildren. .. Patch Set 2: The point of using Java vs JSNI is that since java methods could be used in other parts, the usage of na

[gwt-contrib] Change in gwt[master]: Adds Node#removeAllChildren.

2013-06-20 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Adds Node#removeAllChildren. .. Patch Set 2: Thanks for the detailed analysis. It is good to know that compiler can optimize the null checks. For the inli

[gwt-contrib] Change in gwt[master]: adds type tightening (and tests) for casts inside of RunAsyn...

2013-06-20 Thread Roberto Lublinerman
Roberto Lublinerman has posted comments on this change. Change subject: adds type tightening (and tests) for casts inside of RunAsync onSuccessCalls, resulting in smaller leftover fragments .. Patch Set 2: Code-Review+1 --

[gwt-contrib] Change in gwt[master]: replaces stale jProgram runAsync references and fixes JRunAs...

2013-06-20 Thread Roberto Lublinerman
Roberto Lublinerman has posted comments on this change. Change subject: replaces stale jProgram runAsync references and fixes JRunAsync method inlining to occasionally benefit from tighter types .. Patch Set 1: Code-Review+1

[gwt-contrib] Re: Temporarily disabling CR+2 on Gerrit

2013-06-20 Thread Matthew Dempsky
As a ~24h later status report, we assembled a list of 26 changes that were outstanding, and started working on manually importing them individually so we could parallelize our efforts. It's basically all we've worked on today so far. Current status is: - 12 of them have already been merged.

[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...

2013-06-20 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Patch Set 8: Had to roll this back again due to projects that implement the Im

[gwt-contrib] Change in gwt[master]: Optimize initializing fields at the top scope.

2013-06-20 Thread Stephen Haberman
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3440 to look at the new patch set (#2). Change subject: Optimize initializing fields at the top scope. .. Optimiz

[gwt-contrib] Change in gwt[master]: Optimize initializing fields at the top scope.

2013-06-20 Thread Stephen Haberman
Stephen Haberman has posted comments on this change. Change subject: Optimize initializing fields at the top scope. .. Patch Set 2: Okay, I added a visitor to detect cstrs with polymorphic method calls. Thanks, Roberto, that

[gwt-contrib] Change in gwt[master]: Optimize initializing fields at the top scope.

2013-06-20 Thread Stephen Haberman
Stephen Haberman has posted comments on this change. Change subject: Optimize initializing fields at the top scope. .. Patch Set 1: (1 comment) File dev/core/src/com/google