Re: [gwt-contrib] Re: Temporarily disabling CR+2 on Gerrit

2013-07-02 Thread Manuel Carrasco Moñino
> 1 of them broke gwt-exporter due to the latter depending on GWT internals; > fix is in review Matthew, could you give more info about this break? what is the review number? - Manolo -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you ar

Re: [gwt-contrib] Re: Temporarily disabling CR+2 on Gerrit

2013-07-02 Thread Matthew Dempsky
On Tue, Jul 2, 2013 at 12:59 AM, Manuel Carrasco Moñino wrote: > > 1 of them broke gwt-exporter due to the latter depending on GWT > internals; > > fix is in review > > Matthew, could you give more info about this break? what is the review > number? > Sure, it was https://gwt.googlesource.com/gwt

[gwt-contrib] Change in gwt[master]: Fixes Exception wrapping/unwrapping in compiler

2013-07-02 Thread Roberto Lublinerman
Roberto Lublinerman has posted comments on this change. Change subject: Fixes Exception wrapping/unwrapping in compiler .. Patch Set 1: (2 comments) File dev/core/src/com/g

[gwt-contrib] Change in gwt[master]: Fixes Exception wrapping/unwrapping in compiler

2013-07-02 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Fixes Exception wrapping/unwrapping in compiler .. Patch Set 1: (2 comments) File dev/core/src/com/googl

[gwt-contrib] Change in gwt[master]: Fixes Exception wrapping/unwrapping in compiler

2013-07-02 Thread Goktug Gokdogan
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3601 to look at the new patch set (#2). Change subject: Fixes Exception wrapping/unwrapping in compiler .. Fixes

[gwt-contrib] Change in gwt[master]: Fixes Exception wrapping/unwrapping in compiler

2013-07-02 Thread Roberto Lublinerman
Roberto Lublinerman has posted comments on this change. Change subject: Fixes Exception wrapping/unwrapping in compiler .. Patch Set 2: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3601 To unsubscribe, v

[gwt-contrib] Change in gwt[master]: Optimize initializing fields at the top scope.

2013-07-02 Thread Roberto Lublinerman
Roberto Lublinerman has posted comments on this change. Change subject: Optimize initializing fields at the top scope. .. Patch Set 6: (1 comment) File dev/core/src/com/goo

[gwt-contrib] Change in gwt[master]: Optimize initializing fields at the top scope.

2013-07-02 Thread Stephen Haberman
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3440 to look at the new patch set (#9). Change subject: Optimize initializing fields at the top scope. .. Optimiz

[gwt-contrib] Change in gwt[master]: Optimize initializing fields at the top scope.

2013-07-02 Thread Stephen Haberman
Stephen Haberman has posted comments on this change. Change subject: Optimize initializing fields at the top scope. .. Patch Set 6: (1 comment) Okay, I went with the conservative approach. I'll look forward to hearing wheth