Re: [gwt-contrib] bug in permutations.js?

2014-02-14 Thread Brian Slesinsky
Maybe turn on soft permutations in a sample app, since we do at least test those manually before a release. Long-term, I'd like to see us using soft permutations by default, perhaps to collapse some browser permutations. If it were more commonly used then we'd likely notice that it's broken pretty

Re: [gwt-contrib] bug in permutations.js?

2014-02-14 Thread Stephen Haberman
> Yes it sounds like a bug. Want to add that to the issue tracker? https://code.google.com/p/google-web-toolkit/issues/detail?id=8575 I've verified that the patch fixes the behavior in our application. Any good suggestions about how to test this? Or volunteers to review the patch? Given it was

[gwt-contrib] Re: bug in permutations.js?

2014-02-14 Thread Stephen Haberman
Here is the difference in the generated JS. From a ~10/2013 trunk build: function com_google_gwt_dom_client_StyleInjector_StyleInjectorImpl(){ switch (permutationId) { case 1: case 2: case 3: return new StyleInjector$StyleInjectorImplIE_0; } return new StyleInjector$StyleI

Re: [gwt-contrib] Re: Not able to run GWTTestCase

2014-02-14 Thread Thomas Broyer
On the Eclipse side, I'd check whether the Jetty dependency is "exported" by the gwt-dev project. If it's not, then it won't be on the classpath of tests from the gwt-user project. It might be that we failed to properly update the Eclipse config files when updating Jetty (it does work for me, bu