Re: [gwt-contrib] How to include changesets to an existing gerrit review?

2015-03-09 Thread 'Daniel Kurka' via GWT Contributors
You make the changes in your local git client and amend the commit: 'git commit --amend' Then you just push to gerrit: 'git push origin HEAD:refs/for/master' and this will update the review. On Mon, Mar 9, 2015 at 3:49 PM, Juan Pablo Gardella gardellajuanpa...@gmail.com wrote: Hi all, I've

Re: [gwt-contrib] How to include changesets to an existing gerrit review?

2015-03-09 Thread Juan Pablo Gardella
Thanks Daniel! On 9 March 2015 at 11:55, 'Daniel Kurka' via GWT Contributors google-web-toolkit-contributors@googlegroups.com wrote: You make the changes in your local git client and amend the commit: 'git commit --amend' Then you just push to gerrit: 'git push origin HEAD:refs/for/master'

[gwt-contrib] How to include changesets to an existing gerrit review?

2015-03-09 Thread Juan Pablo Gardella
Hi all, I've started a gerrit review and I have to add to add some improvements due some review observations. How I can include the changes in the same gerrit review? Thanks -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe

Re: [gwt-contrib] Re: GWT 2.8: Turn GSS on by default

2015-03-09 Thread Julien Dramaix
Sorry for my late reply. I'm OK to not remove the code of the old css completely. I will propose another patch for that. That will the make the upgrade unnecessarily harder I just want to mention that the upgrade can be hard because UiBinder's inner style will use GSS by default. And the only