Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

2017-10-07 Thread Thomas Broyer
On Saturday, October 7, 2017 at 5:20:15 PM UTC+2, Thomas Broyer wrote: > > > > On Saturday, October 7, 2017 at 4:54:28 PM UTC+2, Colin Alworth wrote: >> >> Like we do for >> com.google.gwt.junit.RunStyleHtmlUnit.HostedJavaScriptEngine so we can hook >> in the "plugin". Looks like that idea

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

2017-10-07 Thread Thomas Broyer
On Saturday, October 7, 2017 at 4:54:28 PM UTC+2, Colin Alworth wrote: > > Like we do for > com.google.gwt.junit.RunStyleHtmlUnit.HostedJavaScriptEngine so we can hook > in the "plugin". Looks like that idea might be a winner! Just make sure to > swap it in both cases, don't want to kill

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

2017-10-07 Thread Colin Alworth
Like we do for com.google.gwt.junit.RunStyleHtmlUnit.HostedJavaScriptEngine so we can hook in the "plugin". Looks like that idea might be a winner! Just make sure to swap it in both cases, don't want to kill tests in old dev mode. -- You received this message because you are subscribed to the

[gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

2017-10-07 Thread Thomas Broyer
On Saturday, October 7, 2017 at 3:01:52 PM UTC+2, Colin Alworth wrote: > > Exactly - I wasn't planning on adding the javaToJs(), but was going to > unwrap the exception before calling onerror (or have ScriptException > implement Scriptable). Have a short test that demonstrates the issue >

[gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

2017-10-07 Thread Colin Alworth
Exactly - I wasn't planning on adding the javaToJs(), but was going to unwrap the exception before calling onerror (or have ScriptException implement Scriptable). Have a short test that demonstrates the issue without gwt (but wow they have a lot of GWT in their source tree), and am was waiting

[gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

2017-10-07 Thread Thomas Broyer
On Friday, October 6, 2017 at 7:55:15 PM UTC+2, Colin Alworth wrote: > > Okay, I'm about 80% sure that I understand and can remedy the problem > within HtmlUnit itself. Will update once I finish syncing the apparently > canonical SVN repo to git, so I can go over the history more carefully and