Re: [gwt-contrib] Re: Resolving cycle dependency between gwt-safehtml & gwt-safecss

2020-06-26 Thread Chani Liet
i am agree with Vevegoku, atm gwt-resources depends on gwt-safecss and gwt-safehtml. On Fri, Jun 26, 2020 at 4:44 PM Vegegoku wrote: > I see the merge of both into one as the simplest solutions, so +1 to the > merge > > On Thursday, June 25, 2020 at 11:14:46 PM UTC+3, Frank Hossfeld wrote: >> >>

[gwt-contrib] Re: Resolving cycle dependency between gwt-safehtml & gwt-safecss

2020-06-26 Thread Vegegoku
I see the merge of both into one as the simplest solutions, so +1 to the merge On Thursday, June 25, 2020 at 11:14:46 PM UTC+3, Frank Hossfeld wrote: > > To prepare GWT for j2cl we need to move the modules out of GWT, replace > generators with ATP, etc. This is in progress and the first modules

Re: [gwt-contrib] Re: Resolving cycle dependency between gwt-safehtml & gwt-safecss

2020-06-26 Thread Colin Alworth
I may be putting words in Frank's mouth, but I believe the proposal to "merge" these is only to bring them into a single git repository, rather than one repository per module - so option #4 is specifically what he is proposing (with lots of room for optional other changes like 1, 2). We still ve

[gwt-contrib] Re: Resolving cycle dependency between gwt-safehtml & gwt-safecss

2020-06-26 Thread Thomas Broyer
AFAICT, safecss depends on SafeUri only, which currently is in com.google.gwt.safehtml, and safehtml depends on both SafeUri and SafeStyles (though only for their class names during codegen, so optional except for tests). This means that either: 1. we split up a gwt-safeuri (with UriUtils,

Re: [gwt-contrib] Resolving cycle dependency between gwt-safehtml & gwt-safecss

2020-06-26 Thread Michael Conrad
As CSS and HTML are so closely tied to each other in use, having them as separate modules makes me think of excessive DB normalization (and the potential evils thereof). On 6/25/20 4:43 PM, Matt Davis wrote: +1 to merge.