Re: [gwt-contrib] Re: Required JDK version to build GWT?

2020-06-30 Thread Colin Alworth
Thanks Goktug for clarifying - I am personally in favor of a more coarse approach, more future proofed approach that will end up with making changes now rather than later. And to your followup, agreed, all else equal, let's avoid supersource. Thomas - While I made a Java8-first option was the f

Re: [gwt-contrib] Re: Required JDK version to build GWT?

2020-06-30 Thread 'Goktug Gokdogan' via GWT Contributors
(which you already pointed but what matters me the most :)) On Tue, Jun 30, 2020 at 11:39 AM Goktug Gokdogan wrote: > Super sourcing with tests is errorprone; it is easy to get one method > added in one version but note the other and basically you end up testing > nothing. > > On Tue, Jun 30, 20

Re: [gwt-contrib] Re: Required JDK version to build GWT?

2020-06-30 Thread 'Goktug Gokdogan' via GWT Contributors
Super sourcing with tests is errorprone; it is easy to get one method added in one version but note the other and basically you end up testing nothing. On Tue, Jun 30, 2020 at 1:36 AM Thomas Broyer wrote: > So, IIUC, there are 2 distinct issues, but both related to JDK versions. > > First, the d

[gwt-contrib] Re: Required JDK version to build GWT?

2020-06-30 Thread Thomas Broyer
So, IIUC, there are 2 distinct issues, but both related to JDK versions. First, the doclet/taglet where JDK8 has com.sun.javadoc and JDK9+ have jdk.javadoc.doclet. This is an internal tool, so it would be wasted effort to maintain 2 versions. Either we keep the current code and require JDK8, or