[gwt-contrib] Re: Introducing CustomScrollPanel, a subclass of ScrollPanel that lets users define their own scroll... (issue1427804)

2011-04-25 Thread amirkashani
http://gwt-code-reviews.appspot.com/1427804/diff/1/user/src/com/google/gwt/user/client/ui/CustomScrollPanel.java File user/src/com/google/gwt/user/client/ui/CustomScrollPanel.java (right): http://gwt-code-reviews.appspot.com/1427804/diff/1/user/src/com/google/gwt/user/client/ui/CustomScrollPanel

[gwt-contrib] Re: Initial implementation of TabLayoutPanel.

2009-10-14 Thread amirkashani
If I could chime in... http://gwt-code-reviews.appspot.com/78820/diff/1/4 File user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java (right): http://gwt-code-reviews.appspot.com/78820/diff/1/4#newcode365 Line 365: SelectionEvent.fire(this, index); Any chance this could be gated on a issueE

[gwt-contrib] Re: RR : Speed up class selector rewriting

2009-09-21 Thread amirkashani
That was fast, LGTM http://gwt-code-reviews.appspot.com/67807/diff/1/2 File user/src/com/google/gwt/resources/rg/CssResourceGenerator.java (right): http://gwt-code-reviews.appspot.com/67807/diff/1/2#newcode320 Line 320: if (externalClasses.contains(sourceClassName)) { This is the bit I was miss