On 2012/04/05 19:39:54, rdayal wrote:
Ping. Is this patch dead, or do we still want to get this in?
I remember that we were not able to push it into release (2.4 ?).
But this problem is still causing problems in GWT Designer.
http://gwt-code-reviews.appspot.com/1490801/
--
http://groups.googl
lgtm
http://gwt-code-reviews.appspot.com/1604803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/11/29 20:47:56, stephenh wrote:
> should "&& !designTime.isDesignTime()" be added to the test?
Dunno, good question; I added Konstantin as a reviewer.
Konstantin, do you think the assertion in this patch should be skipped
during
design time (the assertion is supposed to warn the u
Reviewers: rjrjr,
Description:
Generate unique class names in AbstractClientBundleGenerator at design
time.
Please review this at http://gwt-code-reviews.appspot.com/1565805/
Affected files:
M
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
Index:
u
Basically these hooks allow you get notification about bean object creation
and provide result for @UiField(provided=true) and @UiFactory.
That's all.
See implementation here:
http://www.google.com/codesearch#A1edwVHBClQ/user/src/com/google/gwt/uibinder/rebind/DesignTimeUtils.java&ct=rc&cd=1&q=De
Reviewers: tobyr,
Description:
Tweak to allow parent ClassLoader at design time.
Please review this at http://gwt-code-reviews.appspot.com/1529803/
Affected files:
M dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
Index: dev/core/src/com/google/gwt/dev/shell/CompilingClassL
Reviewers: zundel,
Description:
Notify DesignTimeUtils about all beans, not only about UIObjects.
Please review this at http://gwt-code-reviews.appspot.com/1483801/
Affected files:
M user/src/com/google/gwt/uibinder/elementparsers/BeanParser.java
M user/src/com/google/gwt/uibinder/elementp
Reviewers: fabbott,
Description:
Adds support for Beans.isDesignTime() for better support in GWT
Designer.
Please review this at http://gwt-code-reviews.appspot.com/1443802/
Affected files:
A user/super/com/google/gwt/emul/java/beans/Beans.java
Index: user/super/com/google/gwt/emul/java/be
Reviewers: scottb,
Description:
Prepares SAXParserFactory one time, so avoids expensive ClassLoader
lokups.
Please review this at http://gwt-code-reviews.appspot.com/1442806/
Affected files:
M dev/core/src/com/google/gwt/dev/util/xml/ReflectiveParser.java
Index: dev/core/src/com/google/gwt
http://gwt-code-reviews.appspot.com/1438801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1438801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: scottb,
Description:
Calculates result of getSourceName() one time, so reuse because of CU
cache.
Prepares SAXParserFActory one time, so avoids expensive ClassLoader
lookups.
Please review this at http://gwt-code-reviews.appspot.com/1438801/
Affected files:
M dev/core/src/com/goog
http://gwt-code-reviews.appspot.com/1420809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1420809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Actually after initial cache filling all these units are used. I see
preparing new TypeData only for changed units, when I modify them and
hit Refresh in DevMode browser.
I've added lazy TypeData into CompiledClass and filling TypeData
information instead of cache. I'm not sure however if adding
http://gwt-code-reviews.appspot.com/1420809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: zundel,
Description:
Adds cache of CollectClassData to make refresh faster.
This gives about 10% performance gain on big projects.
Please review this at http://gwt-code-reviews.appspot.com/1420809/
Affected files:
M dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
A
LGTM
http://gwt-code-reviews.appspot.com/1380808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1388803/diff/3004/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java
File
dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java
(right):
http://gwt-code-reviews.appspot.com/1388803/diff/3004/dev/core/src/com/google/gwt/
http://gwt-code-reviews.appspot.com/1388803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1388803/diff/4001/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java
File
dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java
(right):
http://gwt-code-reviews.appspot.com/1388803/diff/4001/dev/core/src/com/google/gwt/
http://gwt-code-reviews.appspot.com/1388803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1388803/diff/1/dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java
File
dev/core/src/com/google/gwt/dev/resource/impl/ZipFileClassPathEntry.java
(right):
http://gwt-code-reviews.appspot.com/1388803/diff/1/dev/core/src/com/google/gwt/dev/re
http://gwt-code-reviews.appspot.com/1388803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
DevMode uses single top level ModuleDef with single set of jars.
GWT Designer can open several editors with several top level ModuleDefs,
which use several may be different sets of jars, but with many
intersections.
If only we could have hashCode() and equals() for PathPrefixSet... This
would al
Reviewers: conroy,
Description:
Using cached ZipFileClassPathEntry objects.
While this does not give benefits for DevMode, which parses jar files
only once, GWT Designer does this many times.
This gives about 15% speed up in GWT Designer.
Initial.
-
Parsing...done: 4775
refresh: 296
http://gwt-code-reviews.appspot.com/1382801/diff/5008/dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java
File dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java
(right):
http://gwt-code-reviews.appspot.com/1382801/diff/5008/dev/core/src/com/google/gwt/dev/resource/i
http://gwt-code-reviews.appspot.com/1382801/diff/5008/dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java
File dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java
(right):
http://gwt-code-reviews.appspot.com/1382801/diff/5008/dev/core/src/com/google/gwt/dev/resource/i
http://gwt-code-reviews.appspot.com/1382801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1382801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/01/11 18:00:42, jbrosenberg wrote:
I'm not sure I understand the larger picture, but I think there are
some issues
with this approach. Perhaps we can connect up to discuss
furtherHere are
some of the main points to consider:
1. StandardRebindOracle should not know anything spe
On 2011/01/11 16:21:50, scottb wrote:
Generally, can you justify this scheme? I read the article, but I
still don't
understand the advantage of this approach over say, Map
?> where
the key is weak.
Problem happens when you have reference from "value" to "key".
For example, if you try t
Reviewers: rjrjr,
Description:
For Java UI the GWT Designer support dropping TreeItem on Tree and other
TreeItem. We need same feature for UiBinder too. This patch adds parsers
for Tree and TreeItem which support this feature.
Please review this at http://gwt-code-reviews.appspot.com/1233803/sho
if (designTime.isDesignTime()) {
>> > >> -String typeName =
>> > >> ownerField.getType().getRawType().getQualifiedSourceName();
>> > >> -initializer = designTime.getProvidedField(typeName,
>> > >> - ownerField.getName());
>
Reviewers: rjrjr, rice,
Description:
JavaDoc does not show example.
http://google-web-toolkit.googlecode.com/svn/javadoc/2.1/com/google/gwt/uibinder/client/UiChild.html
Changes in this (trivial) patch.
1. Left angle bracket should be quoted.
2. Fix for indentation.
Please review this at htt
Reviewers: rjrjr,
Description:
http://groups.google.com/group/google-web-toolkit-contributors/browse_thread/thread/9832f30485ce48e2
This patch contains:
1. tweak for LengthAttributeParser to support +/- before value;
2. check for negative width/height in LayoutPanelParser;
3. tests for negative
http://gwt-code-reviews.appspot.com/1077802/diff/1/3
File user/src/com/google/gwt/uibinder/rebind/DesignTimeUtilsImpl.java
(right):
http://gwt-code-reviews.appspot.com/1077802/diff/1/3#newcode52
user/src/com/google/gwt/uibinder/rebind/DesignTimeUtilsImpl.java:52:
w.write(" void handle(String pa
Reviewers: rjrjr,
Description:
We need to provide at least some support for @UiField(provided) and
@UiFactory in GWT Designer. At design time we pass "null" as "owner", so
we need to use special design time hooks to create instances of widgets.
Please review this at http://gwt-code-reviews.appsp
Reviewers: rjrjr,
Description:
These annotations allow us use HorizontalSplitPanel, VerticalSplitPanel
and NamedFrame in UiBinder.
Please review this at http://gwt-code-reviews.appspot.com/865801/show
Affected files:
user/src/com/google/gwt/user/client/ui/HorizontalSplitPanel.java
user/src/
Reviewers: rjrjr,
Description:
It turns out that previous patch was not enough.
In new one instead of preventing failing when no owner or field found,
we disable assigning to fields and support for event handlers at all.
However we can not disable them globally, for all UiBinder templates, we
sho
I don't see this patch in SVN yet.
Was it committed?
http://gwt-code-reviews.appspot.com/792801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
This patch contains changes required for reliable editing of "ui:field"
attribute in template and corresponding @UiField in Java. Solved
problems:
1. When GWT Designer calls createAndBindUi(), it can not provide
"owner", because we can not instantiate it, and it is
These caches contain types which have a circular reference pattern
with the
TypeOracle. If we make a hard reference to the cache here, we end up
pinning the
TypeOracle.
You could break hard reference on TypeOracle for example by using weak
reference on "method" from
"ImageResourceGenera
Reviewers: jgw, Ray Ryan,
Description:
I probably already told about this couple years ago, but DeckPanel, as
it is done now, is IMHO not reliable in area of size management. More
precise - using DeckPanel in TabPanel.
TabPanel uses VerticalPanel to host TabBar and DeckPanel, and it set
panel.
Reviewers: Ray Ryan,
Description:
1. Problems in assertFirstHeader().
1.1. invalid condition;
1.2. invalid reference on second argument.
2. Use addStatement() instead of addInitStatement(), because same is
done everywhere.
3. Small tweaks.
4. Set of tests, including all bad cases.
Please review
Reviewers: Ray Ryan,
Description:
See http://code.google.com/p/google-web-toolkit/issues/detail?id=4550
Please review this at http://gwt-code-reviews.appspot.com/702803/show
Affected files:
user/src/com/google/gwt/uibinder/elementparsers/MenuBarParser.java
user/src/com/google/gwt/uibinder/e
1. Should I remove groups only from this AbsolutePanelParser test or
from DesignTimeUtilsTest too?
2. I agree to use sorting methods with tests, however as with formatting
I have one problem. I would like to do this automatically, i.e. just
configure this in "Save Actions". And this means that t
Reviewers: Ray Ryan,
Please review this at http://gwt-code-reviews.appspot.com/715802/show
Affected files:
user/src/com/google/gwt/uibinder/elementparsers/AbsolutePanelParser.java
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
user/src/com/google/gwt/user/client/ui/AbsoluteP
values in XMLElement
>
>
> http://gwt-code-reviews.appspot.com/693801/show
>
--
Konstantin Scheglov,
Instantiations, Inc.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
inderWriter, should have done that a long
>>> time ago. I'll probably tweak it's name while submitting.
>>>
>>>
>>>
>>>
>>> http://gwt-code-reviews.appspot.com/693801/show
>>>
>>
>>
>
--
Konstantin Scheglov,
Instantiations, Inc.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Ray Ryan,
Description:
It uses just "designTime" and "dt" names, nothing specific for GWT
Designer.
Please review this at http://gwt-code-reviews.appspot.com/693801/show
Affected files:
user/src/com/google/gwt/uibinder/elementparsers/BeanParser.java
user/src/com/google/gwt/uibind
t;>> code always produce the same binary. Would appending an md5 sum to the class
>>> name do the trick?
>>>
>>
>> Well, I hope that now it is clear that nothing is going to be "produced"
>> with such "design time" tweaks.
>> At these modes generated code will be exactly same as it is now.
>>
>
> But if we can avoid having alternative behavior at design time life is
> simpler. Would check sums on the generated class names meet that need?
>
Probably yes.
But I think that we should weight what is better/worse - quick check for
design time or more-less time consuming calculation of check sum, plus
having not-so-friendly class names in hosted mode.
--
Konstantin Scheglov,
Instantiations, Inc.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
>
> We could not do this with a timestamp, as it's important that the same code
> always produce the same binary. Would appending an md5 sum to the class name
> do the trick?
>
Well, I hope that now it is clear that nothing is going to be "produced"
with such "design time" tweaks.
At these modes generated code will be exactly same as it is now.
--
Konstantin Scheglov,
Instantiations, Inc.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
ensitive for enums, then enum-like
constant parsers should do same.
Right now I've posted TextAlignConstantParser with low-case-only names.
I would be happy to contribute patch with these changes, if they look OK
for both of you.
Should I replace existing patch with TextAlignConstan
Reviewers: jgw,
Description:
It uses "friendly" names.
I will post patch with adding support for names like this for
horizontal/vertical alignments (in addition, not replace to keep
compatibility with existing code) later.
Please review this at http://gwt-code-reviews.appspot.com/612803/show
A
Reviewers: jgw,
Description:
See discussion
http://groups.google.com/group/google-web-toolkit-contributors/browse_thread/thread/99cc78172a6a9abd
I've check that tests in com.google.gwt.uibinder.All are still green.
Please review this at http://gwt-code-reviews.appspot.com/633802/show
Affected
Reviewers: ,
Description:
I would like to start contributing small changes into UiBinder, mostly
to make it better for GWT Designer.
For beginning I want to contribute two tests.
BTW, why these parsers use so unfriendly names for alignments?
"ALIGN_RIGHT" looks not very good in XML. Why not jus
57 matches
Mail list logo
