If you can finish it up that would be great.
I haven't really had time to figure out the new system. With the old
system I could generate patch files from any of the many computers that
I work on, email it to myself and submit the patch from anywhere. I
can't really do that anymore...
On 2013/
On 2012/09/16 02:36:41, Patrick Tucker wrote:
Anybody?
http://gwt-code-reviews.appspot.com/1832803/
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To un
On 2013/03/19 15:40:06, tbroyer wrote:
I agree, returning the OptionElement seems like a better idea.
http://gwt-code-reviews.appspot.com/1897803/
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups
On 2013/01/17 21:35:09, goktug wrote:
It won't be hard to make one. If someone will push it through I don't
mind creating the patch.
Can someone get this committed?
http://gwt-code-reviews.appspot.com/1884803/
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You recei
Reviewers: ,
Description:
http://code.google.com/p/google-web-toolkit/issues/detail?id=6483
Please review this at http://gwt-code-reviews.appspot.com/1884803/
Affected files:
user/src/com/google/gwt/user/client/ui/ValueListBox.java
Index: user/src/com/google/gwt/user/client/ui/ValueListBox.
Reviewers: kurka.daniel,
Description:
http://code.google.com/p/google-web-toolkit/issues/detail?id=7715
Please review this at http://gwt-code-reviews.appspot.com/1880804/
Affected files:
user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java
Index: user/src/com/google/gwt/user/client/
Reviewers: tbroyer,
Description:
Ensure that a horizontal submenu in a left to right locale is not drawn
off the screen.
Patch from:
http://code.google.com/p/google-web-toolkit/issues/detail?id=3888
Please review this at http://gwt-code-reviews.appspot.com/1876803/
--
http://groups.google.com/
Just a java doc issue.
http://gwt-code-reviews.appspot.com/132806/diff/1/user/src/com/google/gwt/dom/client/Style.java
File user/src/com/google/gwt/dom/client/Style.java (right):
http://gwt-code-reviews.appspot.com/132806/diff/1/user/src/com/google/gwt/dom/client/Style.java#newcode703
user/src/
A little late, but I hasn't run across this problem until yesterday...
http://gwt-code-reviews.appspot.com/1739803/diff/14001/user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java
File user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java
(right):
http://gwt-code-revie
I didn't realize it wasn't cc'd to the group...
http://gwt-code-reviews.appspot.com/1762803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: ,
Description:
Add constructors that allow the user to skip wrapping an ImageResource
in an Image. Sometimes it is more convenient to not have to worry about
the Image.
http://code.google.com/p/google-web-toolkit/issues/detail?id=4714
Please review this at http://gwt-code-reviews.ap
Reviewers: ,
Description:
ValueListBox should implement HasEnabled, functionality can easily be
delegated to the internal ListBox.
http://code.google.com/p/google-web-toolkit/issues/detail?id=6112
Please review this at http://gwt-code-reviews.appspot.com/1832803/
Affected files:
user/src/com
On 2012/06/27 21:12:10, Patrick Tucker wrote:
This is just a javadoc correction, what is the hold up?
https://gwt-code-reviews.appspot.com/1762803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/07/19 20:48:12, tbroyer wrote:
Can this patch be committed?
https://gwt-code-reviews.appspot.com/1785803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/08/09 16:17:26, rkj wrote:
Understandable, seems like an extension of SingleSelectionModel to fit
your specific case would make the most sense here?
http://gwt-code-reviews.appspot.com/1798806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/08/08 22:25:10, skybrian wrote:
Any reason clear() can't be moved into SelectionModel and not make
SingleSelectionModel implement SetSelectionModel? It seems misleading
to make SingleSelectionModel extend SetSelectionModel when it only deals
with one element.
http://gwt-code-reviews.app
On 2012/07/31 18:48:57, skybrian wrote:
LGTM
http://gwt-code-reviews.appspot.com/1801803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/07/30 19:10:14, rdayal wrote:
Since this is just a doc fix can you also fix 4575?
http://code.google.com/p/google-web-toolkit/issues/detail?id=4575
http://gwt-code-reviews.appspot.com/1770803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/07/19 20:27:56, Patrick Tucker wrote:
http://code.google.com/p/google-web-toolkit/issues/detail?id=3533
http://gwt-code-reviews.appspot.com/1785803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: ,
Description:
Issue 3533
Please review this at http://gwt-code-reviews.appspot.com/1785803/
Affected files:
user/src/com/google/gwt/user/client/ui/SuggestBox.java
Index: user/src/com/google/gwt/user/client/ui/SuggestBox.java
==
Reviewers: ,
Description:
Issue 7457
Please review this at http://gwt-code-reviews.appspot.com/1762803/
Affected files:
user/src/com/google/gwt/dom/client/Style.java
Index: user/src/com/google/gwt/dom/client/Style.java
===
---
http://gwt-code-reviews.appspot.com/1739803/diff/1/user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java
File user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java
(right):
http://gwt-code-reviews.appspot.com/1739803/diff/1/user/src/com/google/gwt/user/cellview/client/C
Reviewers: ,
Description:
Style does not currently support the max-height and max-width CSS 2
properties.
Please review this at http://gwt-code-reviews.appspot.com/1736804/
Affected files:
user/src/com/google/gwt/dom/builder/client/DomStylesBuilder.java
user/src/com/google/gwt/dom/builder/s
Reviewers: rchandia,
Please review this at http://gwt-code-reviews.appspot.com/1736803/
Affected files:
user/src/com/google/gwt/dom/builder/client/DomStylesBuilder.java
user/src/com/google/gwt/dom/builder/shared/HtmlStylesBuilder.java
user/src/com/google/gwt/dom/builder/shared/StylesBuil
On 2012/06/05 17:58:08, rchandia wrote:
On 2012/06/05 01:09:12, Patrick Tucker wrote:
> Is this acceptable, or should I modify the patch?
I think the change in this patch is good. What is needed is for this
patch to
also modify
tools/api-checker/config/gwt24_25userApi.conf
to allow the API c
Correct, this is a breaking change but should not cause much commotion.
Currently, Command is an extension of ScheduledCommand, that should
eventually be deprecated and removed from the API. It was changed to
this in order to ease the transition from DeferredCommand to Scheduler.
The interface ch
Reviewers: ,
Description:
VerticalSplitPanel is using DeferredCommand which is deprecated.
Resubmitting 1693803
Please review this at http://gwt-code-reviews.appspot.com/1725803/
Affected files:
user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java
Index: user/src/com/google/gwt/u
I just realized that 'text-overflow' is a CSS3 property. How do you
guys feel about adding CSS3 properties to Style? If its ok, I will add
'text-justify' and 'text-shadow' which are the only other widely
supported text properties.
http://gwt-code-reviews.appspot.com/1723803/
--
http://groups.g
Reviewers: ,
Description:
Added text-overflow, text-indent, and text-transform
Also added a convenience function to GwtSafeStylesUtilsTest:
assertEquals(String, SafeStyles)
Please review this at http://gwt-code-reviews.appspot.com/1723803/
Affected files:
user/src/com/google/gwt/dom/client/S
Reviewers: ,
Description:
Style does not have a getter, setter or clear function for the 'clear'
CSS property.
Please review this at http://gwt-code-reviews.appspot.com/1720803/
Affected files:
user/src/com/google/gwt/dom/client/Style.java
user/src/com/google/gwt/safecss/shared/SafeStylesBu
LGTM
http://gwt-code-reviews.appspot.com/1614808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1714803/diff/1/user/src/com/google/gwt/user/client/ui/Anchor.java
File user/src/com/google/gwt/user/client/ui/Anchor.java (right):
http://gwt-code-reviews.appspot.com/1714803/diff/1/user/src/com/google/gwt/user/client/ui/Anchor.java#newcode87
user/src/com/goog
Reviewers: ,
Please review this at http://gwt-code-reviews.appspot.com/1714803/
Affected files:
user/src/com/google/gwt/dom/client/Style.java
user/src/com/google/gwt/user/client/ui/Anchor.java
user/src/com/google/gwt/user/client/ui/CheckBox.java
--
http://groups.google.com/group/Google
http://gwt-code-reviews.appspot.com/1711803/diff/9001/dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java
File dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java
(right):
http://gwt-code-reviews.appspot.com/1711803/diff/9001/dev/core/src/com/google/gwt/dev/jjs/impl/D
Reviewers: google-web-toolkit-contributors_googlegroups.com,
Description:
http://code.google.com/p/google-web-toolkit/issues/detail?id=7367
http://code.google.com/p/google-web-toolkit/issues/detail?id=7360
Please review this at http://gwt-code-reviews.appspot.com/1702804/
Affected files:
use
Reviewers: ,
Description:
Changes in MenuItem require changes in MenuBar and SuggestBox.
Please review this at http://gwt-code-reviews.appspot.com/1698803/
Affected files:
user/src/com/google/gwt/user/client/ui/MenuBar.java
user/src/com/google/gwt/user/client/ui/MenuItem.java
user/src/com
Reviewers: ,
Please review this at http://gwt-code-reviews.appspot.com/1693804/
Affected files:
user/src/com/google/gwt/user/client/ui/RenderablePanel.java
Index: user/src/com/google/gwt/user/client/ui/RenderablePanel.java
===
Reviewers: ,
Please review this at http://gwt-code-reviews.appspot.com/1697803/
Affected files:
user/src/com/google/gwt/user/client/impl/WindowImplIE.java
Index: user/src/com/google/gwt/user/client/impl/WindowImplIE.java
===
-
Reviewers: ,
Please review this at http://gwt-code-reviews.appspot.com/1696803/
Affected files:
user/src/com/google/gwt/user/client/ui/impl/PopupImplMozilla.java
Index: user/src/com/google/gwt/user/client/ui/impl/PopupImplMozilla.java
===
Reviewers: ,
Please review this at http://gwt-code-reviews.appspot.com/1694804/
Affected files:
user/src/com/google/gwt/jsonp/client/JsonpRequest.java
Index: user/src/com/google/gwt/jsonp/client/JsonpRequest.java
===
--- user/
Reviewers: ,
Please review this at http://gwt-code-reviews.appspot.com/1695804/
Affected files:
user/src/com/google/gwt/user/datepicker/client/DateBox.java
Index: user/src/com/google/gwt/user/datepicker/client/DateBox.java
===
Reviewers: ,
Please review this at http://gwt-code-reviews.appspot.com/1695803/
Affected files:
user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java
Index: user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java
=
Reviewers: ,
Please review this at http://gwt-code-reviews.appspot.com/1694803/
Affected files:
user/src/com/google/gwt/user/client/ui/HorizontalSplitPanel.java
Index: user/src/com/google/gwt/user/client/ui/HorizontalSplitPanel.java
=
Reviewers: ,
Please review this at http://gwt-code-reviews.appspot.com/1693803/
Affected files:
user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java
Index: user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java
=
Reviewers: ,
Description:
DEFAULT_FAST_FORWARD_ROWS should be final
Add constructor SimplePager(TextLocation, boolean, boolean)
Please review this at http://gwt-code-reviews.appspot.com/1692803/
Affected files:
user/src/com/google/gwt/user/cellview/client/SimplePager.java
Index: user/src/co
Reviewers: ,
Please review this at http://gwt-code-reviews.appspot.com/1691803/
Affected files:
user/src/com/google/gwt/user/client/ui/FormPanel.java
Index: user/src/com/google/gwt/user/client/ui/FormPanel.java
===
--- user/sr
Reviewers: ,
Please review this at http://gwt-code-reviews.appspot.com/1690803/
Affected files:
user/src/com/google/gwt/user/client/ui/CaptionPanel.java
Index: user/src/com/google/gwt/user/client/ui/CaptionPanel.java
===
--- u
Reviewers: ,
Description:
The class uses ScheduledCommand in all but 1 place, the import can be
removed all together if we construct a ScheduledCommand instead of a
Command.
Please review this at http://gwt-code-reviews.appspot.com/1689803/
Affected files:
user/src/com/google/gwt/user/client/
Reviewers: ,
Description:
The java doc for the Position enum in Style states that the enum is for
the display CSS property when it is actually for the position CSS
property.
Please review this at http://gwt-code-reviews.appspot.com/1688803/
Affected files:
user/src/com/google/gwt/dom/client/S
Reviewers: ,
Description:
http://code.google.com/p/google-web-toolkit/issues/detail?id=4613
Please review this at http://gwt-code-reviews.appspot.com/1687803/
Affected files:
user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java
Index: user/src/com/google/gwt/user/client/ui/DockLayout
Reviewers: ,
Description:
http://code.google.com/p/google-web-toolkit/issues/detail?id=6493
Please review this at http://gwt-code-reviews.appspot.com/1686803/
Affected files:
user/src/com/google/gwt/dom/client/Style.java
Index: user/src/com/google/gwt/dom/client/Style.java
=
That would be great!
It looks like this fix is also going to take care of issue 5264 via the
addition of setWidgetHidden(Widget, boolean).
Thanks!
http://gwt-code-reviews.appspot.com/1398801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Do you guys have any objections to setting hidden child widget's size to
0 instead of actually changing their display value? Changing the
display value causes Firefox, Chrome and what not to destroy child flash
objects... and setting its size to 0 seems to have caused 0 problems for
me.
http://g
53 matches
Mail list logo