[gwt-contrib] Re: Fix GWT logging in Devmode (issue437801)

2010-05-04 Thread unnurg
http://gwt-code-reviews.appspot.com/437801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix GWT logging in Devmode (issue437801)

2010-05-04 Thread unnurg
On 2010/05/04 21:59:45, unnurg wrote: OK - it turns out that delegating to another LogManager for the server code is not working correctly. Specifically, there's something in the configurations that isn't getting passed on to the serverLogManager. I spent about 3 hours trying to f

[gwt-contrib] Re: Fix GWT logging in Devmode (issue437801)

2010-05-04 Thread unnurg
http://gwt-code-reviews.appspot.com/437801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix GWT logging in Devmode (issue437801)

2010-05-04 Thread unnurg
http://gwt-code-reviews.appspot.com/437801/diff/8001/9003 File /dev/core/src/com/google/gwt/dev/shell/DevModeLogManager.java (right): http://gwt-code-reviews.appspot.com/437801/diff/8001/9003#newcode33 /dev/core/src/com/google/gwt/dev/shell/DevModeLogManager.java:33: protected static class LogMa

[gwt-contrib] Re: Fix GWT logging in Devmode (issue437801)

2010-05-03 Thread unnurg
http://gwt-code-reviews.appspot.com/437801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix GWT logging in Devmode (issue437801)

2010-05-03 Thread unnurg
all done http://gwt-code-reviews.appspot.com/437801/diff/1/3 File /dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java (right): http://gwt-code-reviews.appspot.com/437801/diff/1/3#newcode43 /dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java:43: * should be instantiatin

[gwt-contrib] Re: Implement GWT logging (issue438801)

2010-05-03 Thread unnurg
http://gwt-code-reviews.appspot.com/438801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Implement GWT logging (issue438801)

2010-05-03 Thread unnurg
http://gwt-code-reviews.appspot.com/438801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Implement GWT logging (issue438801)

2010-05-03 Thread unnurg
On 2010/05/04 01:02:17, unnurg wrote: We think that the latest changes to the DevMode fix CL (437801) which not only gives the server and client their own root logger, but now gives each client thread their own root logger, will fix the extra handlers issue, so that code is removed. http://gwt

[gwt-contrib] Re: Implement GWT logging (issue438801)

2010-05-03 Thread unnurg
http://gwt-code-reviews.appspot.com/438801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Implement GWT logging (issue438801)

2010-05-03 Thread unnurg
http://gwt-code-reviews.appspot.com/438801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix GWT logging in Devmode (issue437801)

2010-04-30 Thread unnurg
Reviewers: scottb, Description: Fix GWT logging in Devmode Please review this at http://gwt-code-reviews.appspot.com/437801/show Affected files: M /dev/core/src/com/google/gwt/dev/DevModeBase.java M /dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java A /dev/core/src/com/goog

[gwt-contrib] Re: Beginnings of GWT implementation of java.util.logging (issue341803)

2010-04-29 Thread unnurg
Fred's comments addressed and formatting made slightly prettier http://gwt-code-reviews.appspot.com/341803/diff/26001/27009 File user/src/com/google/gwt/logging/client/HasWidgetsLogHandler.java (right): http://gwt-code-reviews.appspot.com/341803/diff/26001/27009#newcode65 user/src/com/google/gw

[gwt-contrib] Re: Beginnings of GWT implementation of java.util.logging (issue341803)

2010-04-23 Thread unnurg
e/gwt/logging/client/BasicLoggingPopup.java:17: // TODO(unnurg): Make this popup not suck On 2010/04/21 14:58:03, Dan Rice wrote: Can you be specific? Done. http://gwt-code-reviews.appspot.com/341803/diff/1/11 File user/src/com/google/gwt/logging/client/ConsoleLogHandler.java (righ

[gwt-contrib] Re: Beginnings of GWT implementation of java.util.logging (issue341803)

2010-04-23 Thread unnurg
http://gwt-code-reviews.appspot.com/341803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Beginnings of GWT implementation of java.util.logging (issue341803)

2010-04-16 Thread unnurg
On 2010/04/17 00:33:36, unnurg wrote: A couple of things to note about this review Open issues - Where should the Impl classes (and their associated gwt.xml file) go? This is currently in gwt.logging.impl, but the JRE classes themselves are in core, so maybe these should go somewhere in core

[gwt-contrib] Beginnings of GWT implementation of java.util.logging (issue341803)

2010-04-16 Thread unnurg
Reviewers: Dan Rice, Description: Beginnings of GWT implementation of java.util.logging Review by: r...@google.com Please review this at http://gwt-code-reviews.appspot.com/341803/show Affected files: M dev/core/src/com/google/gwt/dev/shell/ModuleSpace.java M samples/hello/src/com/google/gw

[gwt-contrib] Re: Fix the bug where you cannot use up arrow to enter the suggestions box (issue239801)

2010-03-18 Thread unnurg
On 2010/03/18 17:54:20, unnurg wrote: Hmm - not sure why those marker classes showed up in the CL - looking into what I did wrong there... http://gwt-code-reviews.appspot.com/239801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix the bug where you cannot use up arrow to enter the suggestions box (issue239801)

2010-03-18 Thread unnurg
Reviewers: Ray Ryan, Description: Fix the bug where you cannot use up arrow to enter the suggestions box Please review this at http://gwt-code-reviews.appspot.com/239801/show Affected files: D samples/hello/war/WEB-INF/classes/marker D samples/showcase/war/WEB-INF/classes/marker M user/s

<    1   2   3