Revision: 6515 Author: jlaba...@google.com Date: Wed Oct 28 11:45:03 2009 Log: Fixes a bug where JavaToJavaScriptCompiler assumes PropertyOracle#getSelectionProperty will return null if a property is not defined, but it actually throws a BadPropertyException.
Patch by: jlabanca Review by: spoon http://code.google.com/p/google-web-toolkit/source/detail?r=6515 Modified: /trunk/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java ======================================= --- /trunk/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java Tue Oct 27 23:15:10 2009 +++ /trunk/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java Wed Oct 28 11:45:03 2009 @@ -15,6 +15,7 @@ */ package com.google.gwt.dev.jjs; +import com.google.gwt.core.ext.BadPropertyValueException; import com.google.gwt.core.ext.PropertyOracle; import com.google.gwt.core.ext.SelectionProperty; import com.google.gwt.core.ext.TreeLogger; @@ -334,8 +335,9 @@ // blocks, this class now handles non-top level blocks only. SelectionProperty userAgentProperty = null; for (PropertyOracle oracle : propertyOracles) { - userAgentProperty = oracle.getSelectionProperty(logger, "user.agent"); - if (userAgentProperty != null) { + try { + userAgentProperty = oracle.getSelectionProperty(logger, "user.agent"); + } catch (BadPropertyValueException e) { break; } } --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
