Revision: 6759
Author: kpro...@google.com
Date: Mon Nov  9 06:20:12 2009
Log: Fixes two bugs in SOYC dashboard:
1. Initial download size and total download size were flipped
2. When there was one single split point, it wasn't displayed.

Patch by:
Sami Jaber (sami.ja...@gmail.com)
Review by:
kprobst


http://code.google.com/p/google-web-toolkit/source/detail?r=6759

Modified:
  /trunk/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java

=======================================
--- /trunk/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java        
 
Tue Nov  3 07:48:32 2009
+++ /trunk/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java        
 
Mon Nov  9 06:20:12 2009
@@ -445,7 +445,7 @@
      outFile.println("<dl>");
      outFile.println("<dt>Full code size</dt>");
      outFile.println("<dd class=\"value\">"
-        + globalInformation.getInitialCodeBreakdown().sizeAllCode
+        + globalInformation.getTotalCodeBreakdown().sizeAllCode
          + " Bytes</dd>");
      outFile.println("<dd class=\"report\"><a href=\"total-" + permutationId
          + "-overallBreakdown.html\">Report</a></dd>");
@@ -455,7 +455,7 @@
      outFile.println("<dt>Initial download size</dt>");
      // TODO(kprobst) -- add percentage here: (48%)</dd>");
      outFile.println("<dd class=\"value\">"
-        + globalInformation.getTotalCodeBreakdown().sizeAllCode + "  
Bytes</dd>");
+        + globalInformation.getInitialCodeBreakdown().sizeAllCode + "  
Bytes</dd>");
      outFile.println("<dd class=\"report\"><a href=\"initial-" +  
permutationId
          + "-overallBreakdown.html\">Report</a></dd>");
      outFile.println("</dl>");
@@ -486,7 +486,7 @@
      outFile.println("</thead>");
      outFile.println("<tbody>");

-    if (globalInformation.getSplitPointToLocation().size() > 1) {
+    if (globalInformation.getSplitPointToLocation().size() >= 1) {

        int numSplitPoints =  
globalInformation.getSplitPointToLocation().size();
        float maxSize =  
globalInformation.getTotalCodeBreakdown().sizeAllCode;

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to