Revision: 8216
Author: gwt.mirror...@gmail.com
Date: Fri May 28 09:33:23 2010
Log: Moved the Activity subclasses to the App module to break the circular dependency between App and ValueStore.

Review at http://gwt-code-reviews.appspot.com/571801

Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8216

Added:
/branches/2.1/bikeshed/src/com/google/gwt/app/place/AbstractRecordEditActivity.java /branches/2.1/bikeshed/src/com/google/gwt/app/place/AbstractRecordListActivity.java
Deleted:
/branches/2.1/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordEditActivity.java /branches/2.1/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java
Modified:
/branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldMasterActivities.java /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/ListActivitiesMapper.java /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditActivity.java /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeListActivity.java /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportEditActivity.java /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportListActivity.java

=======================================
--- /dev/null
+++ /branches/2.1/bikeshed/src/com/google/gwt/app/place/AbstractRecordEditActivity.java Thu May 27 08:51:15 2010
@@ -0,0 +1,176 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.google.gwt.app.place;
+
+import com.google.gwt.requestfactory.shared.Receiver;
+import com.google.gwt.requestfactory.shared.RequestFactory;
+import com.google.gwt.user.client.Window;
+import com.google.gwt.valuestore.shared.DeltaValueStore;
+import com.google.gwt.valuestore.shared.Record;
+import com.google.gwt.valuestore.shared.SyncResult;
+import com.google.gwt.valuestore.shared.Value;
+import com.google.gwt.valuestore.ui.RecordEditView;
+
+import java.util.Set;
+
+/**
+ * Abstract activity for editing a record.
+ *
+ * @param <R> the type of Record being edited
+ */
+public abstract class AbstractRecordEditActivity<R extends Record> implements
+    Activity, RecordEditView.Delegate {
+
+  private final RequestFactory requests;
+  private final boolean creating;
+  private final RecordEditView<R> view;
+
+  private String id;
+  private String futureId;
+  private DeltaValueStore deltas;
+  private Display display;
+
+  public AbstractRecordEditActivity(RecordEditView<R> view, String id,
+      RequestFactory requests) {
+    this.view = view;
+    this.creating = "".equals(id);
+    this.id = id;
+    this.requests = requests;
+    this.deltas = requests.getValueStore().spawnDeltaView();
+  }
+
+  public void cancelClicked() {
+    if (willStop()) {
+      deltas = null; // silence the next willStop() call when place changes
+      if (creating) {
+        display.showActivityWidget(null);
+      } else {
+        exit();
+      }
+    }
+  }
+
+  public void onCancel() {
+    onStop();
+  }
+
+  public void onStop() {
+    this.display = null;
+  }
+
+  public void saveClicked() {
+    if (deltas.isChanged()) {
+      view.setEnabled(false);
+
+      final DeltaValueStore toCommit = deltas;
+      deltas = null;
+
+ Receiver<Set<SyncResult>> receiver = new Receiver<Set<SyncResult>>() {
+        public void onSuccess(Set<SyncResult> response) {
+          if (display == null) {
+            return;
+          }
+          boolean hasViolations = false;
+          for (SyncResult syncResult : response) {
+            Record syncRecord = syncResult.getRecord();
+            if (creating) {
+              if (futureId == null
+                  || !futureId.equals(syncResult.getFutureId())) {
+                continue;
+              }
+              id = syncRecord.getId();
+            } else {
+              if (!syncRecord.getId().equals(id)) {
+                continue;
+              }
+            }
+            if (syncResult.hasViolations()) {
+              hasViolations = true;
+              view.showErrors(syncResult.getViolations());
+            }
+          }
+          if (!hasViolations) {
+            exit();
+          } else {
+            deltas = toCommit;
+            deltas.clearUsed();
+            view.setEnabled(true);
+            deltas.clearUsed();
+          }
+        }
+
+      };
+      requests.syncRequest(toCommit).to(receiver).fire();
+    }
+  }
+
+  @SuppressWarnings("unchecked")
+  public void start(Display display) {
+    this.display = display;
+
+    view.setDelegate(this);
+    view.setDeltaValueStore(deltas);
+    view.setCreating(creating);
+
+    if (creating) {
+ // TODO shouldn't have to cast like this. Let's get something better than
+      // a string token
+      R tempRecord = (R) deltas.create(getRecordToken());
+      futureId = tempRecord.getId();
+      doStart(display, tempRecord);
+    } else {
+      fireFindRequest(Value.of(id), new Receiver<R>() {
+        public void onSuccess(R record) {
+          if (AbstractRecordEditActivity.this.display != null) {
+            doStart(AbstractRecordEditActivity.this.display, record);
+          }
+        }
+      });
+    }
+  }
+
+  public boolean willStop() {
+    return deltas == null || !deltas.isChanged()
+ || Window.confirm("Are you sure you want to abandon your changes?");
+  }
+
+  /**
+   * Called when the user has clicked Cancel or has successfully saved.
+   */
+  protected abstract void exit();
+
+  /**
+   * Called to fetch the details of the edited record.
+   */
+ protected abstract void fireFindRequest(Value<String> id, Receiver<R> callback);
+
+  protected String getId() {
+    return id;
+  }
+
+  /**
+   * Called to fetch the string token needed to get a new record via
+   * {...@link DeltaValueStore#create}.
+   */
+  protected abstract String getRecordToken();
+
+  private void doStart(final Display display, R record) {
+    view.setEnabled(true);
+    view.setValue(record);
+    view.showErrors(null);
+    display.showActivityWidget(view);
+  }
+}
=======================================
--- /dev/null
+++ /branches/2.1/bikeshed/src/com/google/gwt/app/place/AbstractRecordListActivity.java Thu May 27 08:51:15 2010
@@ -0,0 +1,205 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.google.gwt.app.place;
+
+import com.google.gwt.requestfactory.shared.Receiver;
+import com.google.gwt.requestfactory.shared.RecordListRequest;
+import com.google.gwt.valuestore.shared.Record;
+import com.google.gwt.valuestore.shared.WriteOperation;
+import com.google.gwt.valuestore.ui.RecordListView;
+import com.google.gwt.view.client.ListView;
+import com.google.gwt.view.client.PagingListView;
+import com.google.gwt.view.client.Range;
+import com.google.gwt.view.client.SingleSelectionModel;
+
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Abstract activity for requesting and displaying a list of {...@record}.
+ * <p>
+ * Subclasses must:
+ *
+ * <ul>
+ * <li>implement methods to provide a full count, and request a specific
+ * <li>provide a {...@link RecordListView}
+ * <li>respond to "show details" commands
+ * </ul>
+ *
+ * Only the properties required by the view will be requested.
+ *
+ * @param <R> the type of {...@link Record} listed
+ */
+public abstract class AbstractRecordListActivity<R extends Record> implements
+    Activity, RecordListView.Delegate<R>, ListView.Delegate<R> {
+ private final Map<String, Integer> recordToRow = new HashMap<String, Integer>();
+  private final Map<String, R> idToRecord = new HashMap<String, R>();
+  private final SingleSelectionModel<R> selectionModel;
+
+  private RecordListView<R> view;
+  private Display display;
+
+  public AbstractRecordListActivity(RecordListView<R> view) {
+    this.view = view;
+    view.setDelegate(this);
+    view.asPagingListView().setDelegate(this);
+
+    selectionModel = new SingleSelectionModel<R>() {
+      @Override
+      public void setSelected(R newSelection, boolean selected) {
+        R wasSelected = this.getSelectedObject();
+        super.setSelected(newSelection, selected);
+        if (!newSelection.equals(wasSelected)) {
+          showDetails(newSelection);
+        }
+      }
+    };
+    view.asPagingListView().setSelectionModel(selectionModel);
+  }
+
+  public RecordListView<R> getView() {
+    return view;
+  }
+
+  public void onCancel() {
+    onStop();
+  }
+
+  /**
+   * Called by the table as it needs data.
+   */
+  public void onRangeChanged(ListView<R> listView) {
+    final Range range = listView.getRange();
+
+    final Receiver<List<R>> callback = new Receiver<List<R>>() {
+      public void onSuccess(List<R> values) {
+        if (view == null) {
+          // This activity is dead
+          return;
+        }
+        recordToRow.clear();
+        idToRecord.clear();
+ for (int i = 0, row = range.getStart(); i < values.size(); i++, row++) {
+          R record = values.get(i);
+          recordToRow.put(record.getId(), row);
+          idToRecord.put(record.getId(), record);
+        }
+        getView().asPagingListView().setData(range.getStart(),
+            range.getLength(), values);
+        if (display != null) {
+          display.showActivityWidget(getView());
+        }
+      }
+    };
+
+    createRangeRequest(range).forProperties(getView().getProperties()).to(
+        callback).fire();
+  }
+
+  public void onStop() {
+    view.setDelegate(null);
+    view.asPagingListView().setDelegate(null);
+    view = null;
+  }
+
+  /**
+ * Select the record if it happens to be visible, or clear the selection if
+   * called with null or "".
+   */
+  public void select(String id) {
+    if (id == null || "".equals(id)) {
+      R selected = selectionModel.getSelectedObject();
+      if (selected != null) {
+        selectionModel.setSelected(selected, false);
+      }
+    } else {
+      R record = idToRecord.get(id);
+      if (record != null) {
+        selectionModel.setSelected(record, true);
+      }
+    }
+  }
+
+  public void start(Display display) {
+    this.display = display;
+    init();
+  }
+
+  public void update(WriteOperation writeOperation, R record) {
+    switch (writeOperation) {
+      case UPDATE:
+        update(record);
+        break;
+
+      case DELETE:
+        init();
+        break;
+
+      case CREATE:
+        /*
+ * On create, we presume the new record is at the end of the list, so
+         * fetch the last page of items.
+         */
+        getLastPage();
+        break;
+    }
+  }
+
+  public boolean willStop() {
+    return true;
+  }
+
+  protected abstract RecordListRequest<R> createRangeRequest(Range range);
+
+  protected abstract void fireCountRequest(Receiver<Long> callback);
+
+  protected abstract void showDetails(R record);
+
+  private void getLastPage() {
+    fireCountRequest(new Receiver<Long>() {
+      public void onSuccess(Long response) {
+        PagingListView<R> table = getView().asPagingListView();
+        int rows = response.intValue();
+        table.setDataSize(rows, true);
+        int pageSize = table.getPageSize();
+        int remnant = rows % pageSize;
+        if (remnant == 0) {
+          table.setPageStart(rows - pageSize);
+        } else {
+          table.setPageStart(rows - remnant);
+        }
+        onRangeChanged(table);
+      }
+    });
+  }
+
+  private void init() {
+    fireCountRequest(new Receiver<Long>() {
+      public void onSuccess(Long response) {
+ getView().asPagingListView().setDataSize(response.intValue(), true);
+        onRangeChanged(view.asPagingListView());
+      }
+    });
+  }
+
+  private void update(R record) {
+    Integer row = recordToRow.get(record.getId());
+    getView().asPagingListView().setData(row, 1,
+        Collections.singletonList(record));
+  }
+}
=======================================
--- /branches/2.1/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordEditActivity.java Thu May 27 08:00:00 2010
+++ /dev/null
@@ -1,176 +0,0 @@
-/*
- * Copyright 2010 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not - * use this file except in compliance with the License. You may obtain a copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations under
- * the License.
- */
-package com.google.gwt.valuestore.ui;
-
-import com.google.gwt.app.place.Activity;
-import com.google.gwt.requestfactory.shared.Receiver;
-import com.google.gwt.requestfactory.shared.RequestFactory;
-import com.google.gwt.user.client.Window;
-import com.google.gwt.valuestore.shared.DeltaValueStore;
-import com.google.gwt.valuestore.shared.Record;
-import com.google.gwt.valuestore.shared.SyncResult;
-import com.google.gwt.valuestore.shared.Value;
-
-import java.util.Set;
-
-/**
- * Abstract activity for editing a record.
- *
- * @param <R> the type of Record being edited
- */
-public abstract class AbstractRecordEditActivity<R extends Record> implements
-    Activity, RecordEditView.Delegate {
-
-  private final RequestFactory requests;
-  private final boolean creating;
-  private final RecordEditView<R> view;
-
-  private String id;
-  private String futureId;
-  private DeltaValueStore deltas;
-  private Display display;
-
-  public AbstractRecordEditActivity(RecordEditView<R> view, String id,
-      RequestFactory requests) {
-    this.view = view;
-    this.creating = "".equals(id);
-    this.id = id;
-    this.requests = requests;
-    this.deltas = requests.getValueStore().spawnDeltaView();
-  }
-
-  public void cancelClicked() {
-    if (willStop()) {
-      deltas = null; // silence the next willStop() call when place changes
-      if (creating) {
-        display.showActivityWidget(null);
-      } else {
-        exit();
-      }
-    }
-  }
-
-  public void onCancel() {
-    onStop();
-  }
-
-  public void onStop() {
-    this.display = null;
-  }
-
-  public void saveClicked() {
-    if (deltas.isChanged()) {
-      view.setEnabled(false);
-
-      final DeltaValueStore toCommit = deltas;
-      deltas = null;
-
- Receiver<Set<SyncResult>> receiver = new Receiver<Set<SyncResult>>() {
-        public void onSuccess(Set<SyncResult> response) {
-          if (display == null) {
-            return;
-          }
-          boolean hasViolations = false;
-          for (SyncResult syncResult : response) {
-            Record syncRecord = syncResult.getRecord();
-            if (creating) {
-              if (futureId == null
-                  || !futureId.equals(syncResult.getFutureId())) {
-                continue;
-              }
-              id = syncRecord.getId();
-            } else {
-              if (!syncRecord.getId().equals(id)) {
-                continue;
-              }
-            }
-            if (syncResult.hasViolations()) {
-              hasViolations = true;
-              view.showErrors(syncResult.getViolations());
-            }
-          }
-          if (!hasViolations) {
-            exit();
-          } else {
-            deltas = toCommit;
-            deltas.clearUsed();
-            view.setEnabled(true);
-            deltas.clearUsed();
-          }
-        }
-
-      };
-      requests.syncRequest(toCommit).to(receiver).fire();
-    }
-  }
-
-  @SuppressWarnings("unchecked")
-  public void start(Display display) {
-    this.display = display;
-
-    view.setDelegate(this);
-    view.setDeltaValueStore(deltas);
-    view.setCreating(creating);
-
-    if (creating) {
- // TODO shouldn't have to cast like this. Let's get something better than
-      // a string token
-      R tempRecord = (R) deltas.create(getRecordToken());
-      futureId = tempRecord.getId();
-      doStart(display, tempRecord);
-    } else {
-      fireFindRequest(Value.of(id), new Receiver<R>() {
-        public void onSuccess(R record) {
-          if (AbstractRecordEditActivity.this.display != null) {
-            doStart(AbstractRecordEditActivity.this.display, record);
-          }
-        }
-      });
-    }
-  }
-
-  public boolean willStop() {
-    return deltas == null || !deltas.isChanged()
- || Window.confirm("Are you sure you want to abandon your changes?");
-  }
-
-  /**
-   * Called when the user has clicked Cancel or has successfully saved.
-   */
-  protected abstract void exit();
-
-  /**
-   * Called to fetch the details of the edited record.
-   */
- protected abstract void fireFindRequest(Value<String> id, Receiver<R> callback);
-
-  protected String getId() {
-    return id;
-  }
-
-  /**
-   * Called to fetch the string token needed to get a new record via
-   * {...@link DeltaValueStore#create}.
-   */
-  protected abstract String getRecordToken();
-
-  private void doStart(final Display display, R record) {
-    view.setEnabled(true);
-    view.setValue(record);
-    view.showErrors(null);
-    display.showActivityWidget(view);
-  }
-}
=======================================
--- /branches/2.1/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java Mon May 24 14:18:21 2010
+++ /dev/null
@@ -1,205 +0,0 @@
-/*
- * Copyright 2010 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not - * use this file except in compliance with the License. You may obtain a copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations under
- * the License.
- */
-package com.google.gwt.valuestore.ui;
-
-import com.google.gwt.app.place.Activity;
-import com.google.gwt.requestfactory.shared.Receiver;
-import com.google.gwt.requestfactory.shared.RecordListRequest;
-import com.google.gwt.valuestore.shared.Record;
-import com.google.gwt.valuestore.shared.WriteOperation;
-import com.google.gwt.view.client.ListView;
-import com.google.gwt.view.client.PagingListView;
-import com.google.gwt.view.client.Range;
-import com.google.gwt.view.client.SingleSelectionModel;
-
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-
-/**
- * Abstract activity for requesting and displaying a list of {...@record}.
- * <p>
- * Subclasses must:
- *
- * <ul>
- * <li>implement methods to provide a full count, and request a specific
- * <li>provide a {...@link RecordListView}
- * <li>respond to "show details" commands
- * </ul>
- *
- * Only the properties required by the view will be requested.
- *
- * @param <R> the type of {...@link Record} listed
- */
-public abstract class AbstractRecordListActivity<R extends Record> implements
-    Activity, RecordListView.Delegate<R>, ListView.Delegate<R> {
- private final Map<String, Integer> recordToRow = new HashMap<String, Integer>();
-  private final Map<String, R> idToRecord = new HashMap<String, R>();
-  private final SingleSelectionModel<R> selectionModel;
-
-  private RecordListView<R> view;
-  private Display display;
-
-  public AbstractRecordListActivity(RecordListView<R> view) {
-    this.view = view;
-    view.setDelegate(this);
-    view.asPagingListView().setDelegate(this);
-
-    selectionModel = new SingleSelectionModel<R>() {
-      @Override
-      public void setSelected(R newSelection, boolean selected) {
-        R wasSelected = this.getSelectedObject();
-        super.setSelected(newSelection, selected);
-        if (!newSelection.equals(wasSelected)) {
-          showDetails(newSelection);
-        }
-      }
-    };
-    view.asPagingListView().setSelectionModel(selectionModel);
-  }
-
-  public RecordListView<R> getView() {
-    return view;
-  }
-
-  public void onCancel() {
-    onStop();
-  }
-
-  /**
-   * Called by the table as it needs data.
-   */
-  public void onRangeChanged(ListView<R> listView) {
-    final Range range = listView.getRange();
-
-    final Receiver<List<R>> callback = new Receiver<List<R>>() {
-      public void onSuccess(List<R> values) {
-        if (view == null) {
-          // This activity is dead
-          return;
-        }
-        recordToRow.clear();
-        idToRecord.clear();
- for (int i = 0, row = range.getStart(); i < values.size(); i++, row++) {
-          R record = values.get(i);
-          recordToRow.put(record.getId(), row);
-          idToRecord.put(record.getId(), record);
-        }
-        getView().asPagingListView().setData(range.getStart(),
-            range.getLength(), values);
-        if (display != null) {
-          display.showActivityWidget(getView());
-        }
-      }
-    };
-
-    createRangeRequest(range).forProperties(getView().getProperties()).to(
-        callback).fire();
-  }
-
-  public void onStop() {
-    view.setDelegate(null);
-    view.asPagingListView().setDelegate(null);
-    view = null;
-  }
-
-  /**
- * Select the record if it happens to be visible, or clear the selection if
-   * called with null or "".
-   */
-  public void select(String id) {
-    if (id == null || "".equals(id)) {
-      R selected = selectionModel.getSelectedObject();
-      if (selected != null) {
-        selectionModel.setSelected(selected, false);
-      }
-    } else {
-      R record = idToRecord.get(id);
-      if (record != null) {
-        selectionModel.setSelected(record, true);
-      }
-    }
-  }
-
-  public void start(Display display) {
-    this.display = display;
-    init();
-  }
-
-  public void update(WriteOperation writeOperation, R record) {
-    switch (writeOperation) {
-      case UPDATE:
-        update(record);
-        break;
-
-      case DELETE:
-        init();
-        break;
-
-      case CREATE:
-        /*
- * On create, we presume the new record is at the end of the list, so
-         * fetch the last page of items.
-         */
-        getLastPage();
-        break;
-    }
-  }
-
-  public boolean willStop() {
-    return true;
-  }
-
-  protected abstract RecordListRequest<R> createRangeRequest(Range range);
-
-  protected abstract void fireCountRequest(Receiver<Long> callback);
-
-  protected abstract void showDetails(R record);
-
-  private void getLastPage() {
-    fireCountRequest(new Receiver<Long>() {
-      public void onSuccess(Long response) {
-        PagingListView<R> table = getView().asPagingListView();
-        int rows = response.intValue();
-        table.setDataSize(rows, true);
-        int pageSize = table.getPageSize();
-        int remnant = rows % pageSize;
-        if (remnant == 0) {
-          table.setPageStart(rows - pageSize);
-        } else {
-          table.setPageStart(rows - remnant);
-        }
-        onRangeChanged(table);
-      }
-    });
-  }
-
-  private void init() {
-    fireCountRequest(new Receiver<Long>() {
-      public void onSuccess(Long response) {
- getView().asPagingListView().setDataSize(response.intValue(), true);
-        onRangeChanged(view.asPagingListView());
-      }
-    });
-  }
-
-  private void update(R record) {
-    Integer row = recordToRow.get(record.getId());
-    getView().asPagingListView().setData(row, 1,
-        Collections.singletonList(record));
-  }
-}
=======================================
--- /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldMasterActivities.java Wed May 12 17:53:17 2010 +++ /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ScaffoldMasterActivities.java Thu May 27 08:51:15 2010
@@ -15,6 +15,7 @@
  */
 package com.google.gwt.sample.expenses.gwt.client;

+import com.google.gwt.app.place.AbstractRecordListActivity;
 import com.google.gwt.app.place.Activity;
 import com.google.gwt.app.place.ActivityMapper;
 import com.google.gwt.sample.expenses.gwt.client.place.ListScaffoldPlace;
@@ -23,7 +24,6 @@
 import com.google.gwt.sample.expenses.gwt.client.place.ScaffoldRecordPlace;
 import com.google.gwt.sample.expenses.gwt.ui.ListActivitiesMapper;
 import com.google.gwt.valuestore.shared.Record;
-import com.google.gwt.valuestore.ui.AbstractRecordListActivity;

 /**
* Finds the activity to run for a particular {...@link ScaffoldPlace} in the top
=======================================
--- /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/ListActivitiesMapper.java Thu May 13 07:44:39 2010 +++ /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/ListActivitiesMapper.java Thu May 27 08:51:15 2010
@@ -15,6 +15,7 @@
  */
 package com.google.gwt.sample.expenses.gwt.ui;

+import com.google.gwt.app.place.AbstractRecordListActivity;
 import com.google.gwt.app.place.ActivityMapper;
 import com.google.gwt.app.place.PlaceController;
 import com.google.gwt.event.shared.HandlerManager;
@@ -25,7 +26,6 @@
 import com.google.gwt.sample.expenses.gwt.request.ReportRecord;
 import com.google.gwt.sample.expenses.gwt.ui.employee.EmployeeListActivity;
 import com.google.gwt.sample.expenses.gwt.ui.report.ReportListActivity;
-import com.google.gwt.valuestore.ui.AbstractRecordListActivity;

 /**
* The class that knows what {...@link com.google.gwt.app.place.Activity} to run
=======================================
--- /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditActivity.java Fri May 7 15:22:39 2010 +++ /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditActivity.java Thu May 27 08:51:15 2010
@@ -15,6 +15,7 @@
  */
 package com.google.gwt.sample.expenses.gwt.ui.employee;

+import com.google.gwt.app.place.AbstractRecordEditActivity;
 import com.google.gwt.app.place.PlaceController;
 import com.google.gwt.requestfactory.shared.Receiver;
import com.google.gwt.sample.expenses.gwt.client.place.EmployeeScaffoldPlace;
@@ -23,7 +24,6 @@
 import com.google.gwt.sample.expenses.gwt.request.EmployeeRecord;
 import com.google.gwt.sample.expenses.gwt.request.ExpensesRequestFactory;
 import com.google.gwt.valuestore.shared.Value;
-import com.google.gwt.valuestore.ui.AbstractRecordEditActivity;
 import com.google.gwt.valuestore.ui.RecordEditView;

 /**
=======================================
--- /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeListActivity.java Fri May 7 15:22:39 2010 +++ /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeListActivity.java Thu May 27 08:51:15 2010
@@ -15,6 +15,7 @@
  */
 package com.google.gwt.sample.expenses.gwt.ui.employee;

+import com.google.gwt.app.place.AbstractRecordListActivity;
 import com.google.gwt.app.place.PlaceController;
 import com.google.gwt.event.shared.HandlerManager;
 import com.google.gwt.event.shared.HandlerRegistration;
@@ -26,7 +27,6 @@
 import com.google.gwt.sample.expenses.gwt.request.EmployeeRecord;
 import com.google.gwt.sample.expenses.gwt.request.EmployeeRecordChanged;
 import com.google.gwt.sample.expenses.gwt.request.ExpensesRequestFactory;
-import com.google.gwt.valuestore.ui.AbstractRecordListActivity;
 import com.google.gwt.valuestore.ui.RecordListView;
 import com.google.gwt.view.client.Range;

=======================================
--- /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportEditActivity.java Fri May 7 15:22:39 2010 +++ /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportEditActivity.java Thu May 27 08:51:15 2010
@@ -15,6 +15,7 @@
  */
 package com.google.gwt.sample.expenses.gwt.ui.report;

+import com.google.gwt.app.place.AbstractRecordEditActivity;
 import com.google.gwt.app.place.PlaceController;
 import com.google.gwt.requestfactory.shared.Receiver;
 import com.google.gwt.sample.expenses.gwt.client.place.ReportScaffoldPlace;
@@ -23,7 +24,6 @@
 import com.google.gwt.sample.expenses.gwt.request.ExpensesRequestFactory;
 import com.google.gwt.sample.expenses.gwt.request.ReportRecord;
 import com.google.gwt.valuestore.shared.Value;
-import com.google.gwt.valuestore.ui.AbstractRecordEditActivity;
 import com.google.gwt.valuestore.ui.RecordEditView;

 /**
=======================================
--- /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportListActivity.java Thu May 13 07:44:39 2010 +++ /branches/2.1/bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/report/ReportListActivity.java Thu May 27 08:51:15 2010
@@ -15,6 +15,7 @@
  */
 package com.google.gwt.sample.expenses.gwt.ui.report;

+import com.google.gwt.app.place.AbstractRecordListActivity;
 import com.google.gwt.app.place.PlaceController;
 import com.google.gwt.event.shared.HandlerManager;
 import com.google.gwt.event.shared.HandlerRegistration;
@@ -26,7 +27,6 @@
 import com.google.gwt.sample.expenses.gwt.request.ExpensesRequestFactory;
 import com.google.gwt.sample.expenses.gwt.request.ReportRecord;
 import com.google.gwt.sample.expenses.gwt.request.ReportRecordChanged;
-import com.google.gwt.valuestore.ui.AbstractRecordListActivity;
 import com.google.gwt.valuestore.ui.RecordListView;
 import com.google.gwt.view.client.Range;

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to