Revision: 8416
Author: to...@google.com
Date: Mon Jul 26 13:13:54 2010
Log: Fixes a bug in the finally handling of doExecuteCommands which
unilaterally squashes exceptions. (Early returns from a finally block via
return statements or exceptions override pending exceptions).
Review at http://gwt-code-reviews.appspot.com/699803
Review by: robertvaw...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8416
Modified:
/trunk/user/src/com/google/gwt/user/client/CommandExecutor.java
=======================================
--- /trunk/user/src/com/google/gwt/user/client/CommandExecutor.java Thu Nov
20 14:17:44 2008
+++ /trunk/user/src/com/google/gwt/user/client/CommandExecutor.java Mon Jul
26 13:13:54 2010
@@ -315,16 +315,10 @@
} finally {
wasCanceled = iterator.wasRemoved();
- if (wasCanceled) {
- /*
- * The iterator may have already had its remove method called,
if it
- * has, then we need to exit without updating any state
- */
- return;
- }
-
- if (removeCommand) {
- iterator.remove();
+ if (!wasCanceled) {
+ if (removeCommand) {
+ iterator.remove();
+ }
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
