Author: jlaba...@google.com Date: Wed Apr 29 08:50:28 2009 New Revision: 5305
Modified: trunk/user/src/com/google/gwt/dom/client/DOMImplIE8.java trunk/user/src/com/google/gwt/dom/client/DOMImplTrident.java Log: Moves the IE8 implementation of get/setScrollLeft() from DOMImplTrident to DOMImplIE8 because DOMImplIE6 uses a different version. Patch by: jgw Review by: jlabanca (desk) Modified: trunk/user/src/com/google/gwt/dom/client/DOMImplIE8.java ============================================================================== --- trunk/user/src/com/google/gwt/dom/client/DOMImplIE8.java (original) +++ trunk/user/src/com/google/gwt/dom/client/DOMImplIE8.java Wed Apr 29 08:50:28 2009 @@ -16,4 +16,22 @@ package com.google.gwt.dom.client; class DOMImplIE8 extends DOMImplTrident { + + @Override + public int getScrollLeft(Element elem) { + if (isRTL(elem)) { + // IE8 returns increasingly *positive* values as you scroll left in RTL. + return -super.getScrollLeft(elem); + } + return super.getScrollLeft(elem); + } + + @Override + public void setScrollLeft(Element elem, int left) { + if (isRTL(elem)) { + // IE8 returns increasingly *positive* values as you scroll left in RTL. + left = -left; + } + super.setScrollLeft(elem, left); + } } Modified: trunk/user/src/com/google/gwt/dom/client/DOMImplTrident.java ============================================================================== --- trunk/user/src/com/google/gwt/dom/client/DOMImplTrident.java (original) +++ trunk/user/src/com/google/gwt/dom/client/DOMImplTrident.java Wed Apr 29 08:50:28 2009 @@ -186,15 +186,6 @@ }-*/; @Override - public int getScrollLeft(Element elem) { - if (isRTL(elem)) { - // IE8 returns increasingly *positive* values as you scroll left in RTL. - return -super.getScrollLeft(elem); - } - return super.getScrollLeft(elem); - } - - @Override public native boolean isOrHasChild(Element parent, Element child) /*-{ // An extra equality check is required due to the fact that // elem.contains(elem) is false if elem is not attached to the DOM. @@ -216,15 +207,6 @@ public native void setInnerText(Element elem, String text) /*-{ elem.innerText = text || ''; }-*/; - - @Override - public void setScrollLeft(Element elem, int left) { - if (isRTL(elem)) { - // IE8 returns increasingly *positive* values as you scroll left in RTL. - left = -left; - } - super.setScrollLeft(elem, left); - } private native int getBoundingClientRectLeft(Element elem) /*-{ // getBoundingClientRect() throws a JS exception if the elem is not attached --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---