Reviewers: pquislund_google.com, tbroyer,
Message:
This annotation processor will provide compile-time validation of
RequestFactory interfaces. It produces red-squigglies in Eclipse on
save. The plan is for this to replace the existing
RequestFactoryInterfaceValidator by pre-generating all of the data
needed for the Deobfuscator. The nascent RfApt type can also be
removed.
This is not slated for the 2.4 branch, since it's probably going to take
some soak time to get everything running smoothly.
Run "ant requestfactory" and copy build/lib/requestfactory-apt.jar into
tools/lib/requesfactory. Close, re-open, and clean the gwt-user project
(or whichever project the processor is being run against.
Where the processor incorrectly flags an error, the
@SkipInterfaceValidation annotation can be applied. Also, check
Eclipse's Window -> Show View -> Error Log for any exceptions that
escape the annotation processor.
@Phil,
Since Ray's on vacation, can you take the review on this?
@Thomas,
Your feedback would be very helpful, since you have an RF-based app.
Description:
Add RequestFactory validator implemented as an annotation processor.
This will eventually replace the RequestFactoryInterfaceValidator and
it's classfile-based approach.
Patch by: bobv
Review by: ???
Please review this at http://gwt-code-reviews.appspot.com/1467804/
Affected files:
M eclipse/samples/DynaTableRf/.classpath
A eclipse/samples/DynaTableRf/.factorypath
M user/build.xml
A
user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java
A user/src/com/google/web/bindery/requestfactory/apt/DomainChecker.java
A user/src/com/google/web/bindery/requestfactory/apt/Finder.java
A user/src/com/google/web/bindery/requestfactory/apt/HaltException.java
A user/src/com/google/web/bindery/requestfactory/apt/ProxyScanner.java
A
user/src/com/google/web/bindery/requestfactory/apt/RequestContextScanner.java
A
user/src/com/google/web/bindery/requestfactory/apt/RequestFactoryScanner.java
M user/src/com/google/web/bindery/requestfactory/apt/RfApt.java
A user/src/com/google/web/bindery/requestfactory/apt/RfValidator.java
A user/src/com/google/web/bindery/requestfactory/apt/ScannerBase.java
A user/src/com/google/web/bindery/requestfactory/apt/State.java
A
user/src/com/google/web/bindery/requestfactory/apt/TransportableTypeVisitor.java
M
user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java
M
user/src/com/google/web/bindery/requestfactory/shared/SkipInterfaceValidation.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/FindRequest.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/ProxySerializerImpl.java
M user/test/com/google/web/bindery/requestfactory/shared/BaseFooProxy.java
M
user/test/com/google/web/bindery/requestfactory/shared/SimpleFooProxy.java
M
user/test/com/google/web/bindery/requestfactory/shared/TestFooPolymorphicRequest.java
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
