[gwt-contrib] Change in gwt[master]: Add static is(...) to complement as as(...).

2013-07-09 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Add static is(...) to complement as as(...). .. Patch Set 6: Code-Review+2 (1 comment) I find it strange that CheckStyle didn't flag more whitespace

[gwt-contrib] Change in gwt[master]: Add static is(...) to complement as as(...).

2013-06-13 Thread Thomas Broyer
Hello Goktug Gokdogan, I'd like you to reexamine a rebased change. Please visit https://gwt-review.googlesource.com/2976 to look at the new rebased patch set (#4). Change subject: Add static is(...) to complement as as(...).

[gwt-contrib] Change in gwt[master]: Add static is(...) to complement as as(...).

2013-05-28 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Add static is(...) to complement as as(...). .. Patch Set 1: Code-Review+1 (3 comments) Could you add a test (not for all elements) in ElementTest#testIsOrAs

[gwt-contrib] Change in gwt[master]: Add static is(...) to complement as as(...).

2013-05-28 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Add static is(...) to complement as as(...). .. Patch Set 1: (1 comment) File

[gwt-contrib] Change in gwt[master]: Add static is(...) to complement as as(...).

2013-05-28 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Add static is(...) to complement as as(...). .. Patch Set 1: (1 comment) Commit Message Line 12:

[gwt-contrib] Change in gwt[master]: Add static is(...) to complement as as(...).

2013-05-28 Thread Daniel Kurka
Daniel Kurka has posted comments on this change. Change subject: Add static is(...) to complement as as(...). .. Patch Set 2: Could you rebase on trunk? -- To view, visit https://gwt-review.googlesource.com/2976 To

[gwt-contrib] Change in gwt[master]: Add static is(...) to complement as as(...).

2013-05-28 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Add static is(...) to complement as as(...). .. Patch Set 2: Code-Review+1 I didn't go over all files but I'm ok with the change in principle :) -- To view,