Thomas Broyer has posted comments on this change.
Change subject: Add static is(...) to complement as as(...).
..
Patch Set 6: Code-Review+2
(1 comment)
I find it strange that CheckStyle didn't flag more whitespace
Hello Goktug Gokdogan,
I'd like you to reexamine a rebased change. Please visit
https://gwt-review.googlesource.com/2976
to look at the new rebased patch set (#4).
Change subject: Add static is(...) to complement as as(...).
Thomas Broyer has posted comments on this change.
Change subject: Add static is(...) to complement as as(...).
..
Patch Set 1: Code-Review+1
(3 comments)
Could you add a test (not for all elements) in ElementTest#testIsOrAs
Thomas Broyer has posted comments on this change.
Change subject: Add static is(...) to complement as as(...).
..
Patch Set 1:
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Add static is(...) to complement as as(...).
..
Patch Set 1:
(1 comment)
Commit Message
Line 12:
Daniel Kurka has posted comments on this change.
Change subject: Add static is(...) to complement as as(...).
..
Patch Set 2:
Could you rebase on trunk?
--
To view, visit https://gwt-review.googlesource.com/2976
To
Goktug Gokdogan has posted comments on this change.
Change subject: Add static is(...) to complement as as(...).
..
Patch Set 2: Code-Review+1
I didn't go over all files but I'm ok with the change in principle :)
--
To view,