Brian Slesinsky has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
I agree that we should indirect through JSNI only if the method is actually
private. This
Goktug Gokdogan has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
Actually we discussed this internally and we have an agreement on our side
to add the supp
Roberto Lublinerman has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
The existing code is already fixed.
The question remains whether we want to allow priva
Thomas Broyer has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
A simple "fix" is to only use the JSNI method if the method is private.
And in that case, als
Roberto Lublinerman has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
The JsInliner should take care of this case. Methods that are called in
only one place
Goktug Gokdogan has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
I think there are optimization steps in JS which can reduce the code bloat.
Roberto, can y
Thomas Broyer has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
IIRC, this new behavior is also consistent with @Inject in
google-gin which again makes sense
Brian Slesinsky has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
The surprise comes from violating expectations. I would expect all callers
to a private me
Goktug Gokdogan has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
If somebody thinks that a field/method needs to be package visible for
uibinder then they
Matthew Dempsky has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
Current behavior (forcing it to be package-visible) I think is just an
incident of how gen
Brian Slesinsky has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
I think we need to test this in dev mode with the JDT upgrade. If we're
using the bytecode
Goktug Gokdogan has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
Actually, I encouraged this solution so I will try to answer.
I think enabling private meth
Thomas Broyer has posted comments on this change.
Change subject: Allow @UIHandler annotated methods to be private.
..
Patch Set 2:
As tedious as it can be, I'd rather ask people to fix the projects.
If there are really too m
Roberto Lublinerman has uploaded a new patch set (#2).
Change subject: Allow @UIHandler annotated methods to be private.
..
Allow @UIHandler annotated methods to be private.
Even though @UIHandler annotated methods were not all
Roberto Lublinerman has uploaded a new change for review.
https://gwt-review.googlesource.com/2450
Change subject: Allow @UIHandler annotated methods to be private.
..
Allow @UIHandler annotated methods to be private.
Even
15 matches
Mail list logo
