Thomas Broyer has submitted this change and it was merged.
Change subject: Removes api-checker reference JARs from the source tree.
..
Removes api-checker reference JARs from the source tree.
Now expects them in GWT_TOOLS.
Thomas Broyer has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 5:
Matthew: can I go ahead and merge? Any blocker on Google's side?
--
To view, visit
Hello Matthew Dempsky, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2500
to look at the new patch set (#5).
Change subject: Removes api-checker reference JARs from the source tree.
Matthew Dempsky has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 5: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/2500
To
Matthew Dempsky has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 3:
(1 comment)
Commit Message
Matthew Dempsky has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 3:
(1 comment)
File build.xml
Hello Matthew Dempsky, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2500
to look at the new patch set (#4).
Change subject: Removes api-checker reference JARs from the source tree.
Thomas Broyer has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 3:
(1 comment)
File build.xml
Line
Brian Slesinsky has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 2:
I'm okay with moving things with GWT_TOOLS especially if it means we can
recreate
Hello Matthew Dempsky,
I'd like you to reexamine a rebased change. Please visit
https://gwt-review.googlesource.com/2500
to look at the new rebased patch set (#2).
Change subject: Removes api-checker reference JARs from the source tree.
Matthew Dempsky has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 2:
Oh duh, we'll need to add the .jars to GWT_TOOLS first for the presubmit to
Matthew Dempsky has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 1: Verified-1
Oops, this change failed presubmit. :( More details at
--
To view,
Brian Slesinsky has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 1:
It seems like we should have a separate repo in Gerrit for GWT
dependencies, with
Thomas Broyer has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 1:
A lot of people will tell you that putting binaries in a VCS is a Bad
Thing™, and
Thomas Broyer has uploaded a new change for review.
https://gwt-review.googlesource.com/2500
Change subject: Removes api-checker reference JARs from the source tree.
..
Removes api-checker reference JARs from the source
Thomas Broyer has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 1:
Tested it by downloading the 2.5.1 JARs from Central, saving them in
Matthew Dempsky has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 1:
Seems okay to me in principle.
I take it we'll move gwt-dev.jar and gwt-user.jar
Thomas Broyer has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 1:
When I proposed downloading them from Central or Google Code, Goktug (IIRC)
told me
John A. Tamplin has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 1:
Yes, and many places don't allow build systems unfettered access to the
internet,
Matthew Dempsky has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 1:
Alright, let's go with storing them in GWT_TOOLS for now then.
I think once we move
20 matches
Mail list logo
