Reviewers: bobv,

Description:
Checkpoint CL on the way to making samples/expenses bookmarkable via
activities and places. Introduces some place classes (not yet used),
but mainly reorganizes the code:

* Refactors SlidingPanel out of ExpensesShell

* Refactors a Factory class to be in charge of instantiation. More DI
/ IOC, allows use of PlaceHistoryMapper, and maybe, just maybe, we
can get GIN going.

* Refactors an app class out of the entry point, making the former
trivial.

Next steps are extracting activities out of ExpensesList and
ExpensesDetail, and making the latter work from EntityProxyIds instead
of actual proxies.


Please review this at http://gwt-code-reviews.appspot.com/1013801/show

Affected files:
M samples/expenses/src/main/java/com/google/gwt/sample/expenses/ExpensesCommon.gwt.xml A samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Approval.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseList.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseTree.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Expenses.java A samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobile.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobileShell.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesShell.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesShell.ui.xml M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseDetails.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseEntry.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseList.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportList.java A samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/SlidingPanel.java A samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ioc/Factory.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/AbstractProxyEditActivity.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/AbstractProxyListActivity.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/AbstractProxyListView.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/CreateAndEditProxy.java A samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ExpensesPlaceHistoryMapper.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/FindAndEditProxy.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ProxyDetailsView.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ProxyEditView.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ProxyListPlace.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ProxyListPlacePicker.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ProxyListView.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ProxyPlace.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ProxyPlaceToListPlace.java A samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ReportListPlace.java A samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ReportPlace.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/EmployeeProxy.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/EmployeeRequest.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/ExpenseProxy.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/ExpenseRequest.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/ExpensesEntityTypesProcessor.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/ExpensesRequestFactory.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/ReportProxy.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/request/ReportRequest.java A samples/expenses/src/main/java/com/google/gwt/sample/expenses/shared/EmployeeProxy.java A samples/expenses/src/main/java/com/google/gwt/sample/expenses/shared/EmployeeRequest.java A samples/expenses/src/main/java/com/google/gwt/sample/expenses/shared/ExpenseProxy.java A samples/expenses/src/main/java/com/google/gwt/sample/expenses/shared/ExpenseRequest.java A samples/expenses/src/main/java/com/google/gwt/sample/expenses/shared/ExpensesEntityTypesProcessor.java A samples/expenses/src/main/java/com/google/gwt/sample/expenses/shared/ExpensesRequestFactory.java A samples/expenses/src/main/java/com/google/gwt/sample/expenses/shared/ReportProxy.java A samples/expenses/src/main/java/com/google/gwt/sample/expenses/shared/ReportRequest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to