Are there tests that could be added / updated?

http://gwt-code-reviews.appspot.com/1815803/diff/1/src/com/google/gwt/dom/client/DOMImpl.java
File src/com/google/gwt/dom/client/DOMImpl.java (right):

http://gwt-code-reviews.appspot.com/1815803/diff/1/src/com/google/gwt/dom/client/DOMImpl.java#newcode149
src/com/google/gwt/dom/client/DOMImpl.java:149: public int
eventGetScreenX(NativeEvent evt) {
Should these be made 'final' to make sure subclasses only ever override
the subpixel variants?

http://gwt-code-reviews.appspot.com/1815803/diff/1/src/com/google/gwt/dom/client/DOMImplStandard.java
File src/com/google/gwt/dom/client/DOMImplStandard.java (right):

http://gwt-code-reviews.appspot.com/1815803/diff/1/src/com/google/gwt/dom/client/DOMImplStandard.java#newcode61
src/com/google/gwt/dom/client/DOMImplStandard.java:61: screenY|0,
clientX|0, clientY|0, ctrlKey, altKey, shiftKey, metaKey, button,
How about changing the argument types to `double` instead? (or adding an
overload if we're concerned about binary-compatibility)

`NativeEvent`s generated by the browser can very well contain subpixel
coordinates, so we should be able to generate them from GWT too.
And getting the coordinates out the event would return integer values
anyway (unless you use the subpixel variant), so it's a safe move.

http://gwt-code-reviews.appspot.com/1815803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to