[gwt-contrib] Git commit messages

2013-01-12 Thread Thomas Broyer
+1 Also, see the Discussion section at http://www.kernel.org/pub/software/scm/git/docs/git-commit.html For issues, Gerrit has a feature where using a specific footer line (a line similar to Change-Id, e.g. "Issue:") allows you to search for reviews by the issue number. But I'm fine with just u

Re: [gwt-contrib] Git commit messages

2013-01-11 Thread Goktug Gokdogan
AFAIK, gerrit doesn't generate links for the issues put in the first line. Also it becomes inconsistent when the patch is not for just fixing the issue. I like Matthew's suggestions as it is easy to follow without special cases. On Fri, Jan 11, 2013 at 2:55 PM, John A. Tamplin wrote: > On Fri,

Re: [gwt-contrib] Git commit messages

2013-01-11 Thread John A. Tamplin
On Fri, Jan 11, 2013 at 3:46 PM, Matthew Dempsky wrote: > I'd like to put together some suggestions for writing good Git commit > messages, but there doesn't seem to be any established "style guide" for > this to refer to. > > This one seems like the most popular starting point: > http://tbaggery.

[gwt-contrib] Git commit messages

2013-01-11 Thread Matthew Dempsky
I'd like to put together some suggestions for writing good Git commit messages, but there doesn't seem to be any established "style guide" for this to refer to. This one seems like the most popular starting point: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html In particular,