Reviewers: jgw, Description: Joel, I'm seeing my hosted mode tests fail as noted without this one-liner. It seems that node && node.specified returns undefined, triggering a HostedModeException from JsValueGlue.get(), without something like this == test.
I haven't checked any speed impact of the ==, or whether it intelligently inlines away. Please review this at http://gwt-code-reviews.appspot.com/34833 Affected files: user/src/com/google/gwt/dom/client/DOMImplIE6.java Index: user/src/com/google/gwt/dom/client/DOMImplIE6.java =================================================================== --- user/src/com/google/gwt/dom/client/DOMImplIE6.java (revision 5524) +++ user/src/com/google/gwt/dom/client/DOMImplIE6.java (working copy) @@ -45,7 +45,7 @@ public native boolean hasAttribute(Element elem, String name) /*-{ var node = elem.getAttributeNode(name); - return node && node.specified; + return (node && node.specified) == true; }-*/; /* --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
