Reviewers: jlabanca, Description: This monster of a patch adds what I believe to be full support for IE8.
Review strategy to make your life easier: - All the .gwt.xml files, with the exception of DOM and History just add ie8 to the existing ie6 cases. - The giant diff around both DOMImpl's stems from the fact that in both cases I renamed DOMImplIE6 to DOMImplTrident (Trident is IE's rendering engine), and created IE6 and IE8 subclasses. The IE8 subclasses are currently empty, and I pushed down a few IE6/7-only method implementations into the DOMImplIE6's. - I would save the HistoryImpl changes for last. IE8 implements the HTML5 standard "onhashchange" event, which is going to be the proper way forward on new browsers, so I refactored the implementation such that HistoryImpl uses that. - I also ditched the no-longer-supported Safari 2 history implementation and collapsed the HistoryImplFrame/Safari/IE6 into a single HistoryImplIE6. - I added a new HistoryImplTimer which uses a timer to simulate the "onhashchange" event (this isn't actually a change, just a slight refactoring -- the Mozilla and Safari implementations have always worked this way). Also see this document for some more detail: http://code.google.com/p/google-web-toolkit/wiki/IE8Support Please review this at http://gwt-code-reviews.appspot.com/29803 Affected files: user/src/com/google/gwt/dom/DOM.gwt.xml user/src/com/google/gwt/dom/client/DOMImplIE6.java user/src/com/google/gwt/dom/client/DOMImplIE8.java user/src/com/google/gwt/dom/client/DOMImplTrident.java user/src/com/google/gwt/user/ClippedImage.gwt.xml user/src/com/google/gwt/user/DOM.gwt.xml user/src/com/google/gwt/user/Focus.gwt.xml user/src/com/google/gwt/user/Form.gwt.xml user/src/com/google/gwt/user/History.gwt.xml user/src/com/google/gwt/user/Hyperlink.gwt.xml user/src/com/google/gwt/user/Popup.gwt.xml user/src/com/google/gwt/user/RichText.gwt.xml user/src/com/google/gwt/user/SplitPanel.gwt.xml user/src/com/google/gwt/user/TextBox.gwt.xml user/src/com/google/gwt/user/Tree.gwt.xml user/src/com/google/gwt/user/UserAgent.gwt.xml user/src/com/google/gwt/user/Window.gwt.xml user/src/com/google/gwt/user/client/impl/DOMImplIE6.java user/src/com/google/gwt/user/client/impl/DOMImplIE8.java user/src/com/google/gwt/user/client/impl/DOMImplTrident.java user/src/com/google/gwt/user/client/impl/HistoryImpl.java user/src/com/google/gwt/user/client/impl/HistoryImplFrame.java user/src/com/google/gwt/user/client/impl/HistoryImplIE6.java user/src/com/google/gwt/user/client/impl/HistoryImplMozilla.java user/src/com/google/gwt/user/client/impl/HistoryImplSafari.java user/src/com/google/gwt/user/client/impl/HistoryImplStandard.java user/src/com/google/gwt/user/client/impl/HistoryImplTimer.java user/src/com/google/gwt/xml/XML.gwt.xml user/super/com/google/gwt/emul/EmulationWithUserAgent.gwt.xml --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
