I think I prefer the other option about changing SuggestBox.


https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/client/ui/SuggestBox.java
File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right):

https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/client/ui/SuggestBox.java#newcode104
user/src/com/google/gwt/user/client/ui/SuggestBox.java:104: * @see
ValueBoxBase
Why change this line? (I suppose it's a leftover of the other proposed
patch)

https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/client/ui/SuggestBox.java#newcode107
user/src/com/google/gwt/user/client/ui/SuggestBox.java:107: public class
SuggestBox extends SuggestBoxBase<TextBox> {
Should be TextBoxBase here, not TextBox.

https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/client/ui/SuggestBoxBase.java
File user/src/com/google/gwt/user/client/ui/SuggestBoxBase.java (right):

https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/client/ui/SuggestBoxBase.java#newcode50
user/src/com/google/gwt/user/client/ui/SuggestBoxBase.java:50: public
class SuggestBoxBase<T extends ValueBoxBase<String>> extends Composite
implements HasText, HasFocus,
Javadoc

https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/client/ui/SuggestBoxBase.java#newcode792
user/src/com/google/gwt/user/client/ui/SuggestBoxBase.java:792: public
void hideSuggestionList() {
All those deprecated methods that have been moved to
DefaultSuggestionDisplay should probably stay in SuggestBox.

https://codereview.appspot.com/6494102/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to