Reviewers: scottb,
Description:
Log AssertionErrors thrown by Generators to improve developer
experience.
Fix typo in existing log message.
Patch by: bobv
Review by: scottb
Please review this at http://gwt-code-reviews.appspot.com/362801/show
Affected files:
M dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
Index: dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
===================================================================
--- dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(revision 7941)
+++ dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(working copy)
@@ -435,9 +435,14 @@
msg += "; in " + (after - before) + " ms";
logger.log(TreeLogger.DEBUG, msg, null);
return className;
+ } catch (AssertionError e) {
+ // Catch and log the assertion as a convenience to the developer
+ logger.log(TreeLogger.ERROR, "Generator '" + generatorClass.getName()
+ + "' failed an assertion while rebinding '" + typeName + "'", e);
+ throw new UnableToCompleteException();
} catch (RuntimeException e) {
logger.log(TreeLogger.ERROR, "Generator '" + generatorClass.getName()
- + "' threw threw an exception while rebinding '" + typeName
+ "'", e);
+ + "' threw an exception while rebinding '" + typeName + "'", e);
throw new UnableToCompleteException();
} finally {
PerfLogger.end();
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
