Re: [gwt-contrib] Making Composite implement RequiresResize and ProvidesResize so that it can pass resize informat... (issue1041801)

2010-10-21 Thread John LaBanca
The JavaDoc for RequiresResize says that that instanceof check in onResize if the correct way to to it. An instanceof check should be very fast, and almost negligible compared to the cost of actually doing layout. If somebody notices a performance regression, its easy enough to use a boolean, but

Re: [gwt-contrib] Making Composite implement RequiresResize and ProvidesResize so that it can pass resize informat... (issue1041801)

2010-10-21 Thread Andi Mullaraj
I want to remark something but mine is more a question than a suggestion: I assume OnResize would have to be quite performant. How expensive is the operator instanceof? Is it worth keeping an instance boolean when the child is initialized and check against it later? Or would that be seen more like

[gwt-contrib] Making Composite implement RequiresResize and ProvidesResize so that it can pass resize informat... (issue1041801)

2010-10-21 Thread jlabanca
Reviewers: sbrubaker, Description: Making Composite implement RequiresResize and ProvidesResize so that it can pass resize information to its child widget. This is useful when creating a Composite of a LayoutPanel. In general, a widget should only ProvideResize if its child widget cannot affect