On 2012/08/15 00:27:19, skybrian wrote:
Looks good. I was wondering whether the sort would be slower, but I
looked at
the implementation and it's not using native sort() in any case.
Let's wait until tomorrow to submit, to give people a chance to
respond. LGTM Just adding a comparator shouldn't change whether it uses native sort, since the JS sort allows a comparator. I originally used a native sort + stability fixup pass, but it was a lot slower on IE than a merge sort which was already stable. This was before we had browser-specific implementations in the JRE (StringBuffer), so at some point it might be worth revisiting that and having the current implementation just for IE. Anyway, not really relevant to this change, since it would behave the same in either case. http://gwt-code-reviews.appspot.com/1807805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
