[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

2011-03-24 Thread jlabanca
committed as r9879 http://gwt-code-reviews.appspot.com/1383806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

2011-03-23 Thread pdr
LGTM2 On 2011/03/23 18:07:02, rjrjr wrote: LGTM This is pretty exciting. On Wed, Mar 23, 2011 at 11:05 AM, wrote: > Moving the Default/Negative/Primary Decorations into DefaultAppearance > makes the API much cleaner. > > First, I removed all of the static fa

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

2011-03-23 Thread Ray Ryan
LGTM This is pretty exciting. On Wed, Mar 23, 2011 at 11:05 AM, wrote: > Moving the Default/Negative/Primary Decorations into DefaultAppearance > makes the API much cleaner. > > First, I removed all of the static factory methods (but left some > JavaDoc explaining how to use the different const

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

2011-03-23 Thread jlabanca
Moving the Default/Negative/Primary Decorations into DefaultAppearance makes the API much cleaner. First, I removed all of the static factory methods (but left some JavaDoc explaining how to use the different constructors). Users can just use the default constructor, then call setDecoration() to

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

2011-03-23 Thread jlabanca
http://gwt-code-reviews.appspot.com/1383806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

2011-03-23 Thread rjrjr
http://gwt-code-reviews.appspot.com/1383806/diff/13/user/src/com/google/gwt/cell/client/ButtonCellBase.java File user/src/com/google/gwt/cell/client/ButtonCellBase.java (right): http://gwt-code-reviews.appspot.com/1383806/diff/13/user/src/com/google/gwt/cell/client/ButtonCellBase.java#newcode53

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

2011-03-23 Thread t . broyer
http://gwt-code-reviews.appspot.com/1383806/diff/13/user/src/com/google/gwt/user/widget/client/ButtonBase.java File user/src/com/google/gwt/user/widget/client/ButtonBase.java (right): http://gwt-code-reviews.appspot.com/1383806/diff/13/user/src/com/google/gwt/user/widget/client/ButtonBase.java#n

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

2011-03-23 Thread jlabanca
http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/cell/client/ButtonCellBase.java File user/src/com/google/gwt/cell/client/ButtonCellBase.java (right): http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/cell/client/ButtonCellBase.java#newcod

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

2011-03-23 Thread jlabanca
http://gwt-code-reviews.appspot.com/1383806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

2011-03-22 Thread pdr
A small review--larger one coming up tomorrow. http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/cell/client/ButtonCellBase.java File user/src/com/google/gwt/cell/client/ButtonCellBase.java (right): http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/g

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

2011-03-22 Thread jlabanca
http://gwt-code-reviews.appspot.com/1383806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a new TextButton widget to replace the existing Button widget. The new widget provides th... (issue1383806)

2011-03-22 Thread jlabanca
Test cases coming soon... http://gwt-code-reviews.appspot.com/1383806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors