[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

The general practice I've seen the GWT guys do for that is to do an initial patch where they autoformat, then 2nd patch with the actual changes. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

Looks good. I need to look into how to actually commit this. http://gwt-code-reviews.appspot.com/1529805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

http://gwt-code-reviews.appspot.com/1529805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

http://gwt-code-reviews.appspot.com/1529805/diff/3002/user/src/com/google/gwt/junit/RunStyleHtmlUnit.java File user/src/com/google/gwt/junit/RunStyleHtmlUnit.java (right): http://gwt-code-reviews.appspot.com/1529805/diff/3002/user/src/com/google/gwt/junit/RunStyleHtmlUnit.java#newcode184 user/sr

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

On 2011/08/25 01:56:26, stephenh wrote: Thanks for the review. Agreed on all the nits and updated. Sorry about the line length--I haven't gotten checkstyle installed in Eclipse, nor have auto-format turned on because it seems like a lot of files (like the ones in this review) haven't been

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

Thanks for the review. Agreed on all the nits and updated. Sorry about the line length--I haven't gotten checkstyle installed in Eclipse, nor have auto-format turned on because it seems like a lot of files (like the ones in this review) haven't been reformatted yet. I have a thousand-some warnin

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

http://gwt-code-reviews.appspot.com/1529805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

Makes sense. A few nitpicks. http://gwt-code-reviews.appspot.com/1529805/diff/1/user/src/com/google/gwt/junit/JUnitShell.java File user/src/com/google/gwt/junit/JUnitShell.java (right): http://gwt-code-reviews.appspot.com/1529805/diff/1/user/src/com/google/gwt/junit/JUnitShell.java#newcode1223

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

> I do not think *amitmanjhi *works at Google anymore: Heh, guess not, thanks for pointing that out. Any volunteers for the review then? - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Address RunStyle TODO (issue1529805)

I do not think *amitmanjhi *works at Google anymore: http://www.linkedin.com/profile/view?id=10952047 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors