http://gwt-code-reviews.appspot.com/623803/diff/1/3
File user/src/com/google/gwt/dom/client/DOMImplStandard.java (right):
http://gwt-code-reviews.appspot.com/623803/diff/1/3#newcode115
user/src/com/google/gwt/dom/client/DOMImplStandard.java:115: public
native void addEventListener(EventTarget
http://gwt-code-reviews.appspot.com/623803/diff/1/3
File user/src/com/google/gwt/dom/client/DOMImplStandard.java (right):
http://gwt-code-reviews.appspot.com/623803/diff/1/3#newcode115
user/src/com/google/gwt/dom/client/DOMImplStandard.java:115: public
native void addEventListener(EventTarget
http://gwt-code-reviews.appspot.com/623803/diff/1/3
File user/src/com/google/gwt/dom/client/DOMImplStandard.java (right):
http://gwt-code-reviews.appspot.com/623803/diff/1/3#newcode115
user/src/com/google/gwt/dom/client/DOMImplStandard.java:115: public
native void addEventListener(EventTarget
http://gwt-code-reviews.appspot.com/623803/diff/1/3
File user/src/com/google/gwt/dom/client/DOMImplStandard.java (right):
http://gwt-code-reviews.appspot.com/623803/diff/1/3#newcode115
user/src/com/google/gwt/dom/client/DOMImplStandard.java:115: public
native void addEventListener(EventTarget
LGTM overall.
As a side note, where is the c.g.g.dom.client.EventListener defined?
Could it be made generic? I like how the WebSocket proposal added a base
Event class mimicking the DOM Event interface, with NativeEvent (and
other WebSocket-specific events) extending it. EventListener could
http://gwt-code-reviews.appspot.com/623803/diff/1/3
File user/src/com/google/gwt/dom/client/DOMImplStandard.java (right):
http://gwt-code-reviews.appspot.com/623803/diff/1/3#newcode119
user/src/com/google/gwt/dom/client/DOMImplStandard.java:119:
http://gwt-code-reviews.appspot.com/623803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/623803/diff/1/4
File user/src/com/google/gwt/dom/client/DOMImplTrident.java (right):
http://gwt-code-reviews.appspot.com/623803/diff/1/4#newcode161
user/src/com/google/gwt/dom/client/DOMImplTrident.java:161: // TODO:
Hang on to enough information to implement
On 2010/07/02 16:26:08, tbroyer wrote:
LGTM overall.
As a side note, where is the c.g.g.dom.client.EventListener defined?
Could it be
made generic? I like how the WebSocket proposal added a base Event
class
mimicking the DOM Event interface, with NativeEvent (and other
WebSocket-specific
