[gwt-contrib] Re: Adds support for List collections. Request methods are now permitted to return (issue893801)

2010-09-21 Thread bobv
http://gwt-code-reviews.appspot.com/893801/diff/30001/31001 File user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonProxyCollectionRequest.java (right): http://gwt-code-reviews.appspot.com/893801/diff/30001/31001#newcode69 user/src/com/google/gwt/requestfactory/client/impl/AbstractJs

[gwt-contrib] Re: Adds support for List collections. Request methods are now permitted to return (issue893801)

2010-09-20 Thread cromwellian
Bob noted a missing check for Set, which led me to realize that we had no Set equivalent of RecordListRequest/ProxyListRequest. The lastest patch adds it and fixes the nits. http://gwt-code-reviews.appspot.com/893801/diff/23001/24007 File user/src/com/google/gwt/requestfactory/client/impl/JsoSe

[gwt-contrib] Re: Adds support for List collections. Request methods are now permitted to return (issue893801)

2010-09-20 Thread bobv
LGTM http://gwt-code-reviews.appspot.com/893801/diff/23001/24005 File user/src/com/google/gwt/requestfactory/client/impl/JsoCollection.java (right): http://gwt-code-reviews.appspot.com/893801/diff/23001/24005#newcode39 user/src/com/google/gwt/requestfactory/client/impl/JsoCollection.java:39: *

[gwt-contrib] Re: Adds support for List collections. Request methods are now permitted to return (issue893801)

2010-09-19 Thread mmendez
The patch did not apply cleanly. I went through and tried to provide some feedback anyway. http://gwt-code-reviews.appspot.com/893801/diff/16001/17001 File user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonProxyListRequest.java (right): http://gwt-code-reviews.appspot.com/893801/d

[gwt-contrib] Re: Adds support for List collections. Request methods are now permitted to return (issue893801)

2010-09-17 Thread bobv
http://gwt-code-reviews.appspot.com/893801/diff/1/6 File user/src/com/google/gwt/requestfactory/client/impl/JsoCollection.java (right): http://gwt-code-reviews.appspot.com/893801/diff/1/6#newcode25 user/src/com/google/gwt/requestfactory/client/impl/JsoCollection.java:25: void setDependencies(Del