[gwt-contrib] Re: Allow declared RuntimeExceptions to be correctly propagated

2009-11-20 Thread BobV
Thanks for the review. My only question is anything required for STOB to handle declared RuntimeExceptions, or is this only for deRPC? ProxyCreator.addRemoteServiceRootTypes() iterates over the declared exception types for any given RPC method. It imposes a constraint that they're derived

Re: [gwt-contrib] Re: Allow declared RuntimeExceptions to be correctly propagated

2009-11-20 Thread Lex Spoon
On Fri, Nov 20, 2009 at 9:01 AM, BobV b...@google.com wrote: Thanks for the review. My only question is anything required for STOB to handle declared RuntimeExceptions, or is this only for deRPC? ProxyCreator.addRemoteServiceRootTypes() iterates over the declared exception types for any

Re: [gwt-contrib] Re: Allow declared RuntimeExceptions to be correctly propagated

2009-11-20 Thread John Tamplin
On Fri, Nov 20, 2009 at 1:59 PM, Lex Spoon sp...@google.com wrote: That looks like an accident. It looks like the intent was never to serialize an unchecked exception. When John and I talked about this issue previously, we couldn't come up with an example where you'd really need to

Re: [gwt-contrib] Re: Allow declared RuntimeExceptions to be correctly propagated

2009-11-20 Thread BobV
Including declared RTE's has been there since 1.5. Since the user has explicitly asked for those throwable types, I'm thinking that it's no worse than any other exception type. What we should do as a sanity-check is to explicitly disallow void serviceMethod() throws Exception; void

Re: [gwt-contrib] Re: Allow declared RuntimeExceptions to be correctly propagated

2009-11-20 Thread Lex Spoon
On Fri, Nov 20, 2009 at 2:08 PM, BobV b...@google.com wrote: Including declared RTE's has been there since 1.5.  Since the user has explicitly asked for those throwable types, I'm thinking that it's no worse than any other exception type. Okay, I suppose we are stuck with it, then. I don't

[gwt-contrib] Re: Allow declared RuntimeExceptions to be correctly propagated

2009-11-19 Thread jat
On 2009/11/20 00:10:32, bobv wrote: Review requested. LGTM. My only question is anything required for STOB to handle declared RuntimeExceptions, or is this only for deRPC? http://gwt-code-reviews.appspot.com/106806 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors