[gwt-contrib] Re: Arrays implement Serializable and Cloneable

2009-12-21 Thread spoon
On 2009/12/18 17:37:06, scottb wrote: > http://gwt-code-reviews.appspot.com/125803/diff/1/3 > File dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java (right): > http://gwt-code-reviews.appspot.com/125803/diff/1/3#newcode1032 > Line 1032: allArrayTypes.add(arrayType); > LGTM then. Maybe we coul

[gwt-contrib] Re: Arrays implement Serializable and Cloneable

2009-12-18 Thread scottb
http://gwt-code-reviews.appspot.com/125803/diff/1/3 File dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java (right): http://gwt-code-reviews.appspot.com/125803/diff/1/3#newcode1032 Line 1032: allArrayTypes.add(arrayType); LGTM then. Maybe we could just drop a one-line future-proofer comment a

[gwt-contrib] Re: Arrays implement Serializable and Cloneable

2009-12-18 Thread spoon
http://gwt-code-reviews.appspot.com/125803/diff/1/3 File dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java (right): http://gwt-code-reviews.appspot.com/125803/diff/1/3#newcode480 Line 480: } Will do. http://gwt-code-reviews.appspot.com/125803/diff/1/3#newcode1032 Line 1032: allArrayTypes.add

[gwt-contrib] Re: Arrays implement Serializable and Cloneable

2009-12-17 Thread scottb
Mostly LGTM, just one concern. http://gwt-code-reviews.appspot.com/125803/diff/1/3 File dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java (right): http://gwt-code-reviews.appspot.com/125803/diff/1/3#newcode480 Line 480: } Might add these to INDEX_TYPES and nest inside that block, as in creat