LGTM
http://gwt-code-reviews.appspot.com/1402803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/04/15 15:35:21, zundel wrote:
ping
Despite my minor complaints, but this matches what was proposed so LGTM.
http://gwt-code-reviews.appspot.com/1402803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGETM
I still don't like some of the changes that are being made by these
settings (in particular assignments wrap very strangely), but I guess it
is as good as we are going to get at the moment.
http://gwt-code-reviews.appspot.com/1402803/
--
http://groups.google.com/group/Google-Web-Toolkit-C
ping
http://gwt-code-reviews.appspot.com/1402803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I merged up, so rietveld thinks that every file changed, but in fact,
there are no changes other than the removal of several files not related
to the autoformat.
http://gwt-code-reviews.appspot.com/1402803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
File
tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
(right):
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
File
tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
(right):
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
File
tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
(right):
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/
I still the the assignment line breaks are really ugly this way, but if
others would rather avoid long lines no matter how ugly the result is, I
can go with it.
http://gwt-code-reviews.appspot.com/1402803/diff/6001/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
http://gwt-code-reviews.appspot.com/1402803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
File
tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
(right):
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/
cldr-import mostly looks good, but there are a few consistent issues.
http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
File
tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java
(right):
12 matches
Mail list logo