[gwt-contrib] Re: Avoid Java bottleneck by using explicit Charset for byte[] <-> String conversions. (issue1632803)

2012-04-08 Thread rdayal
On 2012/04/05 18:59:13, rdayal wrote: Jason, can you look at this one more time? Sorry about the delay. Had to make a couple of changes: 1) You can't map null values in a ConcurrentHashMap. Bad suggestion on my part. 2) It's a change in behavior to pass null into readContent. Changed this to pas

[gwt-contrib] Re: Avoid Java bottleneck by using explicit Charset for byte[] <-> String conversions. (issue1632803)

2012-04-08 Thread rdayal
http://gwt-code-reviews.appspot.com/1632803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Avoid Java bottleneck by using explicit Charset for byte[] <-> String conversions. (issue1632803)

2012-04-08 Thread rdayal
On 2012/04/05 19:27:55, Jason Terk wrote: LGTM Thanks, submitted. http://gwt-code-reviews.appspot.com/1632803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Avoid Java bottleneck by using explicit Charset for byte[] <-> String conversions. (issue1632803)

2012-01-31 Thread rdayal
http://gwt-code-reviews.appspot.com/1632803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Avoid Java bottleneck by using explicit Charset for byte[] <-> String conversions. (issue1632803)

2012-01-31 Thread t . broyer
LGTM http://gwt-code-reviews.appspot.com/1632803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Avoid Java bottleneck by using explicit Charset for byte[] <-> String conversions. (issue1632803)

2012-01-30 Thread rdayal
On 2012/01/30 22:31:09, rdayal wrote: http://gwt-code-reviews.appspot.com/1632803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Avoid Java bottleneck by using explicit Charset for byte[] <-> String conversions. (issue1632803)

2012-01-30 Thread rdayal
http://gwt-code-reviews.appspot.com/1632803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors