[gwt-contrib] Re: Basic rough-cut of 1.6 WAR support

2008-12-09 Thread Scott Blum
Yes, we need to implement this method in our implementations, but then not actually call the method anywhere ourselves. On Tue, Dec 9, 2008 at 1:33 PM, Lex Spoon <[EMAIL PROTECTED]> wrote: > On Fri, Dec 5, 2008 at 12:28 PM, BobV <[EMAIL PROTECTED]> wrote: > > - Several classes in user/test/.../s

[gwt-contrib] Re: Basic rough-cut of 1.6 WAR support

2008-12-09 Thread Lex Spoon
On Fri, Dec 5, 2008 at 12:28 PM, BobV <[EMAIL PROTECTED]> wrote: > - Several classes in user/test/.../server/rpc do not compile against > Jetty given the difference in the servlet API in Jetty versus Tomcat. > This is problematic when using an Eclipse project structure that isn't > hamstrung by l

[gwt-contrib] Re: Basic rough-cut of 1.6 WAR support

2008-12-05 Thread Scott Blum
Committed. Thanks, Bob, for the ginormous code review On Fri, Dec 5, 2008 at 7:02 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > Bob, would you mind adding your "notes" to the design doc? > Took your suggestions on JettyLauncher and GWTShell/HostedMode. However, > I'll note that the GWTShell e

[gwt-contrib] Re: Basic rough-cut of 1.6 WAR support

2008-12-05 Thread Scott Blum
Bob, would you mind adding your "notes" to the design doc? Took your suggestions on JettyLauncher and GWTShell/HostedMode. However, I'll note that the GWTShell exit status behavior is long-standing, so this is an explicit change, which is hopefully helpful. On Fri, Dec 5, 2008 at 12:28 PM, BobV <

[gwt-contrib] Re: Basic rough-cut of 1.6 WAR support

2008-12-05 Thread BobV
Notes: - Having two servlet containers that need to be shipped with the distribution seems like it will be problematic from the maintenance perspective. We should aggressively deprecate the current entry points if it is decided that we do want to ship both containers in 1.6. - Several classes