[gwt-contrib] Re: Checkstyle fixes (issue1565806)

2012-06-08 Thread rchandia
Submitted as r11034 http://gwt-code-reviews.appspot.com/1565806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Checkstyle fixes (issue1565806)

2012-06-08 Thread rchandia
LGTM On 2012/06/08 18:27:29, stephenh wrote: > I was putzing around with ant trying to get it to fail the compile so didn't have Eclipse to flag the error. Huh, I thought I had Eclipse configured to show checkstyle errors like that--but I don't see it. I see other errors like methods not i

[gwt-contrib] Re: Checkstyle fixes (issue1565806)

2012-06-08 Thread stephen . haberman
I was putzing around with ant trying to get it to fail the compile so didn't have Eclipse to flag the error. Huh, I thought I had Eclipse configured to show checkstyle errors like that--but I don't see it. I see other errors like methods not in alphabetical order. Resubmitting. I hope the

[gwt-contrib] Re: Checkstyle fixes (issue1565806)

2012-06-08 Thread stephen . haberman
Line length. Oh no! That was completely fine before adding those generics. :-) I was putzing around with ant trying to get it to fail the compile so didn't have Eclipse to flag the error. Resubmitting. http://gwt-code-reviews.appspot.com/1565806/ -- http://groups.google.com/group/Google-Web-

[gwt-contrib] Re: Checkstyle fixes (issue1565806)

2012-06-08 Thread rchandia
LGTM. With a Nit. http://gwt-code-reviews.appspot.com/1565806/diff/8001/user/test/com/google/gwt/editor/client/DirtyEditorTest.java File user/test/com/google/gwt/editor/client/DirtyEditorTest.java (right): http://gwt-code-reviews.appspot.com/1565806/diff/8001/user/test/com/google/gwt/editor/cli

[gwt-contrib] Re: Checkstyle fixes (issue1565806)

2012-06-07 Thread Rodrigo Chandia
I guess it is a difference between OpenJDK and Oracle JDK. On Thu, Jun 7, 2012 at 12:33 PM, wrote: > > Oh, sorry, it breaks test compilation (that is, 'cd user; ant >> test.htmlunit', for example), that is. >> > > That works for me too. :-) > > > > http://gwt-code-reviews.**appspot.com/1565806/

[gwt-contrib] Re: Checkstyle fixes (issue1565806)

2012-06-07 Thread stephen . haberman
Oh, sorry, it breaks test compilation (that is, 'cd user; ant test.htmlunit', for example), that is. That works for me too. :-) http://gwt-code-reviews.appspot.com/1565806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Checkstyle fixes (issue1565806)

2012-06-07 Thread Rodrigo Chandia
Oh, sorry, it breaks test compilation (that is, 'cd user; ant test.htmlunit', for example), that is. On Thu, Jun 7, 2012 at 12:04 PM, wrote: > > Should be ...(ListEditor. of(... >> > > I must be doing something wrong? This compiles in both Eclipse and "ant > clean dist-dev" for me. I'm using a

[gwt-contrib] Re: Checkstyle fixes (issue1565806)

2012-06-07 Thread stephen . haberman
Should be ...(ListEditor. of(... I must be doing something wrong? This compiles in both Eclipse and "ant clean dist-dev" for me. I'm using a JDK 1.6 compiler. I will still change it, but should I make any changes to my local environment to catch stuff like this going forward? http://gwt-code

[gwt-contrib] Re: Checkstyle fixes (issue1565806)

2012-06-07 Thread rchandia
http://gwt-code-reviews.appspot.com/1565806/diff/4001/user/test/com/google/gwt/editor/client/DirtyEditorTest.java File user/test/com/google/gwt/editor/client/DirtyEditorTest.java (right): http://gwt-code-reviews.appspot.com/1565806/diff/4001/user/test/com/google/gwt/editor/client/DirtyEditorTest

[gwt-contrib] Re: Checkstyle fixes (issue1565806)

2012-06-06 Thread stephen . haberman
Reviewers: rjrjr, rdayal, rchandia, Message: Please keep the license header as it was before. Done. Please review this at http://gwt-code-reviews.appspot.com/1565806/ Affected files: M dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java M dev/core/src/com/g