[gwt-contrib] Re: CloneStatementVisitor

2009-09-11 Thread Lex Spoon
On Fri, Sep 11, 2009 at 4:25 PM, Scott Blum wrote: > Gotcha.  Okay that makes sense.  At the same time, I can't help but wonder > if the idea of retargeting to new params/locals couldn't somehow be baked > into the Cloners to force the issue. Conceivably a statement could be cloned and then put

[gwt-contrib] Re: CloneStatementVisitor

2009-09-11 Thread Scott Blum
Gotcha. Okay that makes sense. At the same time, I can't help but wonder if the idea of retargeting to new params/locals couldn't somehow be baked into the Cloners to force the issue. On Fri, Sep 11, 2009 at 3:52 PM, Ray Cromwell wrote: > > That's currently handled by the new inliner, which I'

[gwt-contrib] Re: CloneStatementVisitor

2009-09-11 Thread Ray Cromwell
That's currently handled by the new inliner, which I'll be dropping hopefully today after I drop the Flattener/Unflattener and some other stuff. Basically, each method-call param is assigned to a temp, and for each local in the target method, a new temp local is created. CloneStatementVisitor is ru

[gwt-contrib] Re: CloneStatementVisitor

2009-09-11 Thread scottb
The one thing I don't understand is how you handle locals and params? If you clone an expression or statements from one method into another, how do you handle the fact that local refs and params target the wrong method? Otherwise LGTM. http://gwt-code-reviews.appspot.com/66802 --~--~-~-