[gwt-contrib] Re: Code Review Request: Fix DevMode Server Hang on Unclean Shutdown of Remote UI

2009-11-10 Thread rdayal
Committed as tr...@r6804. Cherry-picked into releases/2.0 at r6805. http://gwt-code-reviews.appspot.com/100801 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Code Review Request: Fix DevMode Server Hang on Unclean Shutdown of Remote UI

2009-11-10 Thread jat
LGTM http://gwt-code-reviews.appspot.com/100801/diff/1/2 File dev/core/src/com/google/gwt/dev/shell/BrowserListener.java (right): http://gwt-code-reviews.appspot.com/100801/diff/1/2#newcode61 Line 61: listenSocket = new ServerSocket(); On 2009/11/10 19:02:17, rdayal wrote: > On 2009/11/10 18:50

[gwt-contrib] Re: Code Review Request: Fix DevMode Server Hang on Unclean Shutdown of Remote UI

2009-11-10 Thread rdayal
Thanks for the review guys. http://gwt-code-reviews.appspot.com/100801/diff/1/2 File dev/core/src/com/google/gwt/dev/shell/BrowserListener.java (right): http://gwt-code-reviews.appspot.com/100801/diff/1/2#newcode61 Line 61: listenSocket = new ServerSocket(); On 2009/11/10 18:50:22, jat wrote: >

[gwt-contrib] Re: Code Review Request: Fix DevMode Server Hang on Unclean Shutdown of Remote UI

2009-11-10 Thread mmendez
LGTM http://gwt-code-reviews.appspot.com/100801 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Code Review Request: Fix DevMode Server Hang on Unclean Shutdown of Remote UI

2009-11-10 Thread jat
LGTM with one question http://gwt-code-reviews.appspot.com/100801/diff/1/2 File dev/core/src/com/google/gwt/dev/shell/BrowserListener.java (right): http://gwt-code-reviews.appspot.com/100801/diff/1/2#newcode61 Line 61: listenSocket = new ServerSocket(); Why the change of not passing port to the