[gwt-contrib] Re: Code Review Request - Issue 1385 - TextBoxBase.selectAll/getSelectedText throws exception

2008-09-18 Thread John LaBanca
The problem is, we can't assert that the element isn't visible because that isn't an efficient or reliable thing to check, and we don't really want to throw an exception at runtime in FF if somebody is developing in IE and may not test FF thoroughly. So, I think its better to fail cleanly. If

[gwt-contrib] Re: Code Review Request - Issue 1385 - TextBoxBase.selectAll/getSelectedText throws exception

2008-09-18 Thread Emily Crutcher
I'm not entirely sure I understand why you can't use the slightly more efficient check in getSelectedText(), but as that is only a speed optimization , LGTM. On Thu, Sep 18, 2008 at 3:40 PM, John LaBanca [EMAIL PROTECTED] wrote: IE throws an exception if the cursorPos is negative, whereas the

[gwt-contrib] Re: Code Review Request - Issue 1385 - TextBoxBase.selectAll/getSelectedText throws exception

2008-09-18 Thread Emily Crutcher
Thanks! On Thu, Sep 18, 2008 at 4:13 PM, John LaBanca [EMAIL PROTECTED] wrote: committed as r3666 I see what you are saying about the more efficient version, so I changed it to the following where we don't get the length unless we need to: public String getSelectedText() { int