Yes, I'll upload it in a sec.
Dan
On Thu, Aug 5, 2010 at 1:12 PM, Ray Ryan rj...@google.com wrote:
Ready for re-review?
On Wed, Aug 4, 2010 at 1:39 PM, r...@google.com wrote:
http://gwt-code-reviews.appspot.com/722802/show
--
http://gwt-code-reviews.appspot.com/722802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
One nit, one refactor request
http://gwt-code-reviews.appspot.com/722802/diff/15001/16001
File user/src/com/google/gwt/view/client/DefaultSelectionModel.java
(right):
http://gwt-code-reviews.appspot.com/722802/diff/15001/16001#newcode62
I'm assuming you meant:
sm.setSelected(foo, !sm.isSelected(foo));
sm.setSelected(foo, !sm.isSelected(foo));
To do this I need some temp storage to be able to compare the final
state when the event is about to be fired to the previous state at the
same point in the code. Is this situation
http://gwt-code-reviews.appspot.com/722802/diff/1/2
File user/src/com/google/gwt/view/client/DefaultSelectionModel.java
(right):
http://gwt-code-reviews.appspot.com/722802/diff/1/2#newcode84
user/src/com/google/gwt/view/client/DefaultSelectionModel.java:84:
scheduleSelectionChangeEvent();
It
http://gwt-code-reviews.appspot.com/722802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
If I do this:
sm.setSelected(!foo, sm.isSelected());
sm.setSelected(!foo, sm.isSelected());
I'll still see an event. Given your nifty event coalescing, I wouldn't
have to. Should you do it there instead?
Also, I wonder if NoSelectionModel is the exception to the no bounces
please rule.
http://gwt-code-reviews.appspot.com/722802/diff/1/2
File user/src/com/google/gwt/view/client/DefaultSelectionModel.java
(right):
http://gwt-code-reviews.appspot.com/722802/diff/1/2#newcode84
user/src/com/google/gwt/view/client/DefaultSelectionModel.java:84:
scheduleSelectionChangeEvent();
