[gwt-contrib] Re: Disable regex checking of URLs in SafeUriHostedModeUtils; this regex appears to (issue1443813)

2011-06-08 Thread Christoph Kern
On Wed, Jun 8, 2011 at 08:00, wrote: > On 2011/06/08 14:48:12, tbroyer wrote: > >> On 2011/06/07 16:34:24, xtof wrote: >> > Thomas, here's a patch that adds a test case to repro the bug >> > > FYI, with openjdk-6-sdk on Ubuntu 11.04, the test passes, but the >> testFromTrustedString_withInvalidU

[gwt-contrib] Re: Disable regex checking of URLs in SafeUriHostedModeUtils; this regex appears to (issue1443813)

2011-06-08 Thread t . broyer
On 2011/06/08 15:00:42, tbroyer wrote: On 2011/06/08 14:48:12, tbroyer wrote: > On 2011/06/07 16:34:24, xtof wrote: > > Thomas, here's a patch that adds a test case to repro the bug > > FYI, with openjdk-6-sdk on Ubuntu 11.04, the test passes, but the > testFromTrustedString_withInvalidUrl fails

[gwt-contrib] Re: Disable regex checking of URLs in SafeUriHostedModeUtils; this regex appears to (issue1443813)

2011-06-08 Thread t . broyer
On 2011/06/08 14:48:12, tbroyer wrote: On 2011/06/07 16:34:24, xtof wrote: > Thomas, here's a patch that adds a test case to repro the bug FYI, with openjdk-6-sdk on Ubuntu 11.04, the test passes, but the testFromTrustedString_withInvalidUrl fails to throw the expected IllegalArgumentException

[gwt-contrib] Re: Disable regex checking of URLs in SafeUriHostedModeUtils; this regex appears to (issue1443813)

2011-06-08 Thread t . broyer
On 2011/06/07 16:34:24, xtof wrote: Thomas, here's a patch that adds a test case to repro the bug FYI, with openjdk-6-sdk on Ubuntu 11.04, the test passes, but the testFromTrustedString_withInvalidUrl fails to throw the expected IllegalArgumentException; which means the "surrogate-pair detectio

[gwt-contrib] Re: Disable regex checking of URLs in SafeUriHostedModeUtils; this regex appears to (issue1443813)

2011-06-07 Thread t . broyer
On 2011/06/07 16:34:24, xtof wrote: Thomas, here's a patch that adds a test case to repro the bug (also changing uses of fromTrustedString to fromSafeConstant where appropriate). Would you be able to look into rewriting the regex? My best guess is that it's falling afoul of http://bugs.sun

[gwt-contrib] Re: Disable regex checking of URLs in SafeUriHostedModeUtils; this regex appears to (issue1443813)

2011-06-07 Thread Christoph Kern
Thomas, here's a patch that adds a test case to repro the bug (also changing uses of fromTrustedString to fromSafeConstant where appropriate). Would you be able to look into rewriting the regex? My best guess is that it's falling afoul of http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5050507;

[gwt-contrib] Re: Disable regex checking of URLs in SafeUriHostedModeUtils; this regex appears to (issue1443813)

2011-06-06 Thread rjrjr
LGTM On 2011/06/06 21:48:51, xtof wrote: http://gwt-code-reviews.appspot.com/1443813/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Disable regex checking of URLs in SafeUriHostedModeUtils; this regex appears to (issue1443813)

2011-06-06 Thread xtof
http://gwt-code-reviews.appspot.com/1443813/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors