[gwt-contrib] Re: EditorDriver#setConstraintViolations used to thrown NPE if arg was null. (issue1826803)

2012-09-11 Thread t . broyer
On 2012/09/10 22:57:14, skybrian wrote: I don't know this code, but since pushViolations() and iterableFromConstraintViolations() are both public methods, under the principle of being conservative about what you send and liberal about what you receive, it seems like

[gwt-contrib] Re: EditorDriver#setConstraintViolations used to thrown NPE if arg was null. (issue1826803)

2012-09-11 Thread skybrian
There's a usage in Google code as well, but it looks like it can't pass in a null. I'd rather fix iterableFromConstrantViolations [sic] but I don't care much, so submitting. https://gwt-code-reviews.appspot.com/1826803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: EditorDriver#setConstraintViolations used to thrown NPE if arg was null. (issue1826803)

2012-09-10 Thread skybrian
I don't know this code, but since pushViolations() and iterableFromConstraintViolations() are both public methods, under the principle of being conservative about what you send and liberal about what you receive, it seems like iterableFromConstraintViolations() should return an empty iterable

[gwt-contrib] Re: EditorDriver#setConstraintViolations used to thrown NPE if arg was null. (issue1826803)

2012-09-09 Thread jat
https://gwt-code-reviews.appspot.com/1826803/diff/2001/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java File user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java (right):

[gwt-contrib] Re: EditorDriver#setConstraintViolations used to thrown NPE if arg was null. (issue1826803)

2012-09-09 Thread t . broyer
https://gwt-code-reviews.appspot.com/1826803/diff/2001/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java File user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java (right):